Always close connection after reloading types in migration. #3465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
mb/9.0.4-migration-close-connection
branch
from
c3e4236 to
192e2d6
Compare
roji
approved these changes
Feb 15, 2025
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Thanks, that looks like a silly oversight indeed.
Have rebased your PR against main, and will backport after merging there.
roji
pushed a commit
that referenced
this pull request
Feb 15, 2025
roji
pushed a commit
that referenced
this pull request
Feb 15, 2025
Member
roji
pushed a commit
that referenced
this pull request
Mar 1, 2025
This was referenced Nov 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3464
Branch is derived from hotix/9.0.4
If not wanted there, it could probably be cherry picked elsewhere.