Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs for range operators #409

Merged
merged 3 commits into from
May 16, 2018

Conversation

austindrenski
Copy link
Contributor

This updates mapping-and-translation.md to reflect #323.

  • Changes "datatype" to "data type" per the PostgreSQL docs
  • Changes [Column] to ColumnAttribute (the bracket form is already in the example)
  • Adds some inline code formatting (e.g. "string" to string)
  • Adds inline code formatting to the table entries

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austindrenski, it's great to get some docs contributions as well.

I'm merging your PR, but in fact I was planning on creating a separate page for ranges only. I'm pretty sure most users coming to Npgsql EF Core simply aren't aware of PostgreSQL ranges, and would benefit from a page concentrating information on them.

@roji roji merged commit 7f760ca into npgsql:dev May 16, 2018
@roji
Copy link
Member

roji commented May 16, 2018

See https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/blob/dev/doc/mapping/range.md for a separate page I wrote for ranges.

(I plan to clean up the entire documentation a bit for the RTM...)

@austindrenski austindrenski deleted the range-operators-docs branch May 24, 2018 17:29
@austindrenski austindrenski self-assigned this Aug 16, 2018
@austindrenski austindrenski added the documentation Improvements or additions to documentation label Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants