Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SQL generator #543

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Refactor SQL generator #543

merged 1 commit into from
Jul 25, 2018

Conversation

austindrenski
Copy link
Contributor

@austindrenski austindrenski commented Jul 25, 2018 •
edited
Loading

  • Add doc comments
  • Reorganize methods into regions for Generators and Visitors
  • Make new methods virtual for consistency
  • Add [NotNull] to params on new methods for consistency

@austindrenski austindrenski self-assigned this Jul 25, 2018
@austindrenski austindrenski mentioned this pull request Jul 25, 2018
Closed
@austindrenski austindrenski force-pushed the refactor-sql-generator branch 5 times, most recently from 2ca6b57 to 8b3a575 Compare July 25, 2018 04:18
@austindrenski austindrenski changed the title Refactor SQL generator before 541 Refactor SQL generator Jul 25, 2018
@austindrenski austindrenski merged commit 94033c0 into npgsql:dev Jul 25, 2018
@austindrenski austindrenski deleted the refactor-sql-generator branch July 25, 2018 04:54
@roji roji added cleanup and removed refactor labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@austindrenski austindrenski

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austindrenski @roji