Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented IGeometry.IsWithinDistance using ST_DWithin #740

Merged
merged 1 commit into from
Dec 9, 2018
Merged

Implemented IGeometry.IsWithinDistance using ST_DWithin #740

merged 1 commit into from
Dec 9, 2018

Conversation

EricStG
Copy link
Contributor

@EricStG EricStG commented Dec 8, 2018

Contributes to #457

@EricStG
Copy link
Contributor Author

EricStG commented Dec 8, 2018

Guessing QueryBaseline.cs is autogenerated?

austindrenski
austindrenski approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@austindrenski austindrenski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for putting it together.

We'll have to keep an eye on NetTopologySuite/GeoAPI#46, which considers making this an extension method.

@austindrenski austindrenski added the enhancement New feature or request label Dec 8, 2018
@austindrenski austindrenski added this to the 3.0.0 milestone Dec 8, 2018
YohDeadfall
YohDeadfall approved these changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@YohDeadfall YohDeadfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think that the spatial functions should be logically grouped, but separately from this PR.

@roji roji merged commit 9799897 into npgsql:dev Dec 9, 2018
@roji
Copy link
Member

roji commented Dec 9, 2018

Merged, thanks for your contribution!

@EricStG EricStG deleted the iswithindistance branch December 12, 2018 21:01
@ArcadeRenegade
Copy link

Thanks!

@ArcadeRenegade ArcadeRenegade mentioned this pull request Apr 23, 2019
Closed
@roji roji mentioned this pull request Apr 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@YohDeadfall YohDeadfall YohDeadfall approved these changes

@austindrenski austindrenski austindrenski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EricStG @roji @ArcadeRenegade @YohDeadfall @austindrenski