Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new NTS translations #851

Merged
merged 5 commits into from
May 21, 2019
Merged

Added new NTS translations #851

merged 5 commits into from
May 21, 2019

Conversation

EricStG
Copy link
Contributor

@EricStG EricStG commented Mar 16, 2019

Added Geometry.Buffer(double, int)
Added Geometry.InteriorPoint
Added Geometry.OgcGeometryType
Added Geometry.Union()

Contributes to #457

Added Geometry.Buffer(double, int)
Added Geometry.InteriorPoint
Added Geometry.OgcGeometryType
Added Geometry.Union()
…etTopologySuiteMemberTranslatorPlugin.cs


Fixed indentation

Co-Authored-By: EricStG <EricStG@users.noreply.github.com>
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question to confirm from me, and otherwise agree with @YohDeadfall's comments.

@austindrenski austindrenski added the enhancement New feature or request label Mar 30, 2019
Reduced ST_Buffer case statements in NpgsqlGeometryMethodTranslator to one
Removed superflous private modifier
@EricStG
Copy link
Contributor Author

EricStG commented May 21, 2019

Hi, just wondering what's missing here to close this?

@austindrenski
Copy link
Contributor

Nope nothing missing here!

@austindrenski austindrenski merged commit 472b13b into npgsql:dev May 21, 2019
@austindrenski
Copy link
Contributor

Thanks for your contribution (and patience) @EricStG!

austindrenski pushed a commit that referenced this pull request May 21, 2019
- Geometry.Buffer(double, int)
- Geometry.InteriorPoint
- Geometry.OgcGeometryType
- Geometry.Union()
@EricStG EricStG deleted the st_buffer branch October 25, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants