This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Ensure that root is added when root.meta is set #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the root metadata (name, version, and the package[''] member) to be missing when we replace the metadata object on the root node during the buildIdealTree step (which we do for 'npm update' with no package name args). Implicitly add the node to the metadata whenever node.meta is set. This required a bit of shuffling around and the removal of some cases where we _were_ explicitly adding the root node, since it is now no longer a thing that can be forgotten. Fix: npm/cli#1997
ruyadorno
approved these changes
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the root metadata (name, version, and the package['']
member) to be missing when we replace the metadata object on the root
node during the buildIdealTree step (which we do for 'npm update' with
no package name args).
Implicitly add the node to the metadata whenever node.meta is set. This
required a bit of shuffling around and the removal of some cases where
we were explicitly adding the root node, since it is now no longer a
thing that can be forgotten.
Fix: npm/cli#1997