This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Make dependencies' sort locale independent #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At issue here isn't the differences between 6 and 7, its the idempotency of the action. The results shouldn't differ based on end user locale. This PR is going to be unable to merge after #273 is landed, because this function was inlined into So while I think this is a good change, we'll have to wait for the other PR to land so this one can be re-applied there. We will also want to have a test that goes inside the |
|
Other places where we use |
|
Ok, new plan. Instead of dropping |
isaacs
added a commit
that referenced
this pull request
May 6, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
isaacs
added a commit
that referenced
this pull request
May 6, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
isaacs
added a commit
that referenced
this pull request
May 7, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
|
Going with the approach in #280. Thanks for bringing this to our attention! |
isaacs
added a commit
that referenced
this pull request
May 10, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
isaacs
added a commit
that referenced
this pull request
May 10, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
wraithgar
pushed a commit
that referenced
this pull request
May 10, 2021
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix npm's sorting of dependencies in
package.jsonnpm/cli#2829now dependencies in
package.jsonare sorted locale dependent, which makes npm unusable on non-english systemssame problem was fixed in 2017 https://github.com/npm/npm/pull/17844/files but now sorting package.json and package-lock.json are again locale independend in npm 7
for me this is a big issue, because some of us in our company is working with english OS, some in slovak and both package.json and package-lock files are changing with every npm install
if you are on *nix system, you can test
LC_ALL=sk npm iandLC_ALL=en-US npm i(as described in issue above). but on windows there is no way to change sort language.npm 6 from 2017 fix use native
.sort(), which useC.UTF-8sort, now npm 7 use localeCompare, which changed sorting even on English systems:-is now after_.so fixing this by forcing sorting to
en-USlocale makes npm 6 and npm 7 dependencies sorted different