This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix extraneous deps on load-actual #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading an actual tree sometimes extraneous deps were not being properly marked as so, since they were not really marked as extraneous at the moment of reify, so in order to be strictly correct we need to recalculate deps at load-actual in order to make sure extraneous deps are properly marked as such. Related to: npm/cli#2554 PR-URL: npm#289 Credit: @ruyadorno Close: npm#289 Reviewed-by: @isaacs
isaacs
force-pushed
the
recalc-dep-flags-when-loading-actual
branch
from
b4a2a4e to
271dd5f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an actual tree sometimes extraneous deps were not being
properly marked as so, since they were not really marked as extraneous
at the moment of reify, so in order to be strictly correct we need to
recalculate deps at load-actual in order to make sure extraneous deps
are properly marked as such.
References
Related to: npm/cli#2554