This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
chore: @npmcli/package-json refactor #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes lib/update-root-package-json.js in favor of using @npmcli/package-json for reading and modifying package.json during reify. Relates to: npm/statusboard#368
ruyadorno
force-pushed
the
use-package-json-refactor
branch
from
7a8c339 to
15c4903
Compare
wraithgar
reviewed
Jun 24, 2021
| @@ -31952,7 +31952,7 @@ exports[`test/arborist/reify.js TAP save proper lockfile with bins when upgradin | |||
| ` | |||
|
|
|||
| exports[`test/arborist/reify.js TAP save-prod, with optional > must match snapshot 1`] = ` | |||
| {"optionalDependencies":{},"dependencies":{"abbrev":"^1.1.1"}} | |||
| {"dependencies":{"abbrev":"^1.1.1"}} | |||
wraithgar
approved these changes
Jun 24, 2021
nlf
approved these changes
Jun 24, 2021
| ) | ||
| }) | ||
|
|
||
| t.test('custom formatting', async t => { |
There was a problem hiding this comment.
we don't have a test for this in @npmcli/package-json, feels like we should add one. i see the code that should do this, but it's always a good idea to prove it works as intended
There was a problem hiding this comment.
we actually have! 😅 I added it as part of https://github.com/npm/package-json/blob/main/test/index.js#L50 which is easy to see in the snapshot: https://github.com/npm/package-json/blob/main/tap-snapshots/test/index.js.test.cjs#L12 but I see how confusing that is from a maintenance point of view! 😬
I'll swap that test to just use regular formatting and move that check to a custom formatting separated test! thanks for bringing that up!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
lib/update-root-package-json.jsin favor of using@npmcli/package-jsonfor reading and modifyingpackage.jsonduringreify.
References
Relates to: npm/statusboard#368