fix: show more information during publish dry-run

Fixes #4317
npm · Apr 13, 2022 · 5ba7f0c · 5ba7f0c
1 parent 06eff18
commit 5ba7f0c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 19 deletions.
diff --git a/lib/commands/publish.js b/lib/commands/publish.js
@@ -102,19 +102,20 @@ class Publish extends BaseCommand {
       logTar(pkgContents, { unicode })
     }
 
+    const resolved = npa.resolve(manifest.name, manifest.version)
+    const registry = npmFetch.pickRegistry(resolved, opts)
+    const creds = this.npm.config.getCredentialsByURI(registry)
+    const outputRegistry = replaceInfo(registry)
+    if (!creds.token && !creds.username) {
+      throw Object.assign(
+        new Error(`This command requires you to be logged in to ${outputRegistry}`), {
+          code: 'ENEEDAUTH',
+        }
+      )
+    }
+    log.notice('', `Publishing to ${outputRegistry}${dryRun ? ' (dry-run)' : ''}`)
+
     if (!dryRun) {
-      const resolved = npa.resolve(manifest.name, manifest.version)
-      const registry = npmFetch.pickRegistry(resolved, opts)
-      const creds = this.npm.config.getCredentialsByURI(registry)
-      const outputRegistry = replaceInfo(registry)
-      if (!creds.token && !creds.username) {
-        throw Object.assign(
-          new Error(`This command requires you to be logged in to ${outputRegistry}`), {
-            code: 'ENEEDAUTH',
-          }
-        )
-      }
-      log.notice('', `Publishing to ${outputRegistry}`)
       await otplease(opts, opts => libpub(manifest, tarballData, opts))
     }
 

diff --git a/test/lib/commands/publish.js b/test/lib/commands/publish.js
@@ -163,9 +163,9 @@ t.test('if loglevel=info and json, should not output package contents', async t
 
 t.test(
   /* eslint-disable-next-line max-len */
-  'if loglevel=silent and dry-run, should not output package contents or publish or validate credentials, should log tarball contents',
+  'if loglevel=silent and dry-run, should not output package contents or publish, should log tarball contents',
   async t => {
-    t.plan(1)
+    t.plan(2)
 
     const testDir = t.testdir({
       'package.json': JSON.stringify(
@@ -199,8 +199,9 @@ t.test(
         throw new Error('should not output in dry run mode')
       },
     }, t)
-    npm.config.getCredentialsByURI = () => {
-      throw new Error('should not call getCredentialsByURI in dry run')
+    npm.config.getCredentialsByURI = uri => {
+      t.same(uri, npm.config.get('registry'), 'gets credentials for expected registry')
+      return { token: 'some.registry.token' }
     }
 
     const publish = new Publish(npm)
@@ -213,7 +214,7 @@ t.test(
   /* eslint-disable-next-line max-len */
   'if loglevel=info and dry-run, should not publish, should log package contents and log tarball contents',
   async t => {
-    t.plan(2)
+    t.plan(3)
 
     const testDir = t.testdir({
       'package.json': JSON.stringify(
@@ -247,9 +248,11 @@ t.test(
         t.pass('output fn is called')
       },
     }, t)
-    npm.config.getCredentialsByURI = () => {
-      throw new Error('should not call getCredentialsByURI in dry run')
+    npm.config.getCredentialsByURI = uri => {
+      t.same(uri, npm.config.get('registry'), 'gets credentials for expected registry')
+      return { token: 'some.registry.token' }
     }
+
     const publish = new Publish(npm)
 
     await publish.exec([testDir])