Skip to content

Commit

Permalink
chore: use packlist to write node_module ignores (#5363)
Browse files Browse the repository at this point in the history
The gitignore file inside `node_modules/` is now an allow list built
from the output of `npm-packlist`. This means that the only dependencies
that get checked in to source control are those that will end up in the
packed tarball, with the exception of some files that we always ignore.

This also moves the dependencies required to build the docs workspace
from devDependencies to dependencies so they are available for making
the docs after pruning. Ignoring these from source control was the
reason that the change to how we build the gitignore file was necessary.
  • Loading branch information
lukekarrys committed Oct 5, 2022
1 parent e9eda68 commit 92e94e3
Show file tree
Hide file tree
Showing 39 changed files with 823 additions and 14,596 deletions.
324 changes: 323 additions & 1 deletion DEPENDENCIES.md

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion docs/.eslintrc.local.json

This file was deleted.

15 changes: 9 additions & 6 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,21 @@
"url": "https://github.com/npm/cli.git",
"directory": "docs"
},
"devDependencies": {
"dependencies": {
"@mdx-js/mdx": "^1.6.22",
"cmark-gfm": "^0.9.0",
"jsdom": "^18.1.0",
"marked-man": "^0.7.0",
"mkdirp": "^1.0.4",
"yaml": "^1.10.2"
},
"devDependencies": {
"@npmcli/eslint-config": "^3.1.0",
"@npmcli/fs": "^2.1.0",
"@npmcli/promise-spawn": "^3.0.0",
"@npmcli/template-oss": "4.5.0",
"cmark-gfm": "^0.9.0",
"jsdom": "^18.1.0",
"marked-man": "^0.7.0",
"tap": "^16.0.1",
"which": "^2.0.2",
"yaml": "^1.10.0"
"which": "^2.0.2"
},
"author": "GitHub Inc.",
"license": "ISC",
Expand Down
Loading

0 comments on commit 92e94e3

Please sign in to comment.