Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] npm version doesn't create git commit/tag in subpackages #1082

Closed
gmrchk opened this issue Mar 30, 2020 · 5 comments
Closed

[QUESTION] npm version doesn't create git commit/tag in subpackages #1082

gmrchk opened this issue Mar 30, 2020 · 5 comments
Labels
Awaiting Information further information is requested

Comments

@gmrchk
Copy link

gmrchk commented Mar 30, 2020

What / Why

When running npm version major or any other npm version command in sub-package (eg. monorepo with packages/subpackage folder), git commit and git tag is not created for the git repository, while the package.json and package-lock.json files are updated in a subpackage.
Is this expected behavior?

Where

  • n/a

Who

  • n/a

References

  • n/a
@gmrchk gmrchk changed the title [BUG] npm version doesn't create git commit/tag in subfolders [QUESTION] npm version doesn't create git commit/tag in subfolders Mar 30, 2020
@gmrchk gmrchk changed the title [QUESTION] npm version doesn't create git commit/tag in subfolders [QUESTION] npm version doesn't create git commit/tag in subpackages Mar 30, 2020
@bradym
Copy link

bradym commented Apr 8, 2020

Looking into this myself today I came across npm/npm#9111

@ZYinMD
Copy link

ZYinMD commented Jul 7, 2020

Had this issue too. I think it's reasonable that a tag should not be created, because there may be multiple sub folders that contain different package.json files with different versions, so none of them should dictate the git tag. However, I do think it's reasonable to create a commit. Without the commit I'm left with a dirty tree after npm version patch. Maybe the commit message could be `${project name} {version}`

@gmrchk
Copy link
Author

gmrchk commented Jul 10, 2020

@ZYinMD I think the same goes for the git tag, which could have the same format in general, so we would be on a safe side whether it's a monorepo containing more packages or just single package repo. But you're right, at least the commit would be enough.

@darcyclarke darcyclarke added the Awaiting Information further information is requested label Oct 30, 2020
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

1 similar comment
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Information further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants