-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUESTION] npm version doesn't create git commit/tag in subpackages #1082
Comments
Looking into this myself today I came across npm/npm#9111 |
Had this issue too. I think it's reasonable that a tag should not be created, because there may be multiple sub folders that contain different package.json files with different versions, so none of them should dictate the git tag. However, I do think it's reasonable to create a commit. Without the commit I'm left with a dirty tree after |
@ZYinMD I think the same goes for the git tag, which could have the same format in general, so we would be on a safe side whether it's a monorepo containing more packages or just single package repo. But you're right, at least the commit would be enough. |
npm If your bug is preproducible on If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo Closing: This is an automated message. |
1 similar comment
npm If your bug is preproducible on If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo Closing: This is an automated message. |
What / Why
When running
npm version major
or any othernpm version
command in sub-package (eg. monorepo withpackages/subpackage
folder), git commit and git tag is not created for the git repository, while thepackage.json
andpackage-lock.json
files are updated in a subpackage.Is this expected behavior?
Where
Who
References
The text was updated successfully, but these errors were encountered: