Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v7.x npm_config_* flags not being set for boolean values #1650

Closed
MylesBorins opened this issue Aug 10, 2020 · 0 comments
Closed

[BUG] v7.x npm_config_* flags not being set for boolean values #1650

MylesBorins opened this issue Aug 10, 2020 · 0 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@MylesBorins
Copy link
Contributor

Current Behavior:

When running npm install --extra-parameter the npm_config_extra_param ENV VAR is not being set.
It does set when passing a string e.g. npm install --extra-parameter=cool, but not when explicitly set to a boolean e.g. npm install --extra-parameter=true or npm install --extra-parameter=1

Expected Behavior:

Running npm install with additional boolean parameter should set the appropriate ENV VAR

Steps To Reproduce:

$ git clone https://github.com/bzoz/omg-i-pass-with-install-param.git
$ cd omg-i-pass-with-install-param
$ npm install --extra-param

The above fails on 7.x and passes on 6.x

Environment:

OS: MacOS 10.15.6
Node: 14.6.0
npm: 7.0.0-beta.2

@MylesBorins MylesBorins added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Needs Triage needs review for next steps labels Aug 10, 2020
isaacs added a commit that referenced this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

1 participant