[BUG] npx fails with "could not find executable" when running husky in v7 #1845

csvn · 2020-09-22T13:31:39Z

The latest version of husky is broken in npm v7. I'm not sure if this regression is intended or not, i.e. if Husky needs to be updated or npm needs a bugfix.

Current Behavior:

~ npx husky-run pre-commit
npm ERR! could not determine executable to run

npm ERR! A complete log of this run can be found in:
...

Expected Behavior:

~ npx husky-run pre-commit
husky > pre-commit (node v14.10.1)
Hello World!
...

Steps To Reproduce:

Create a new empty folder and run npm init -y inside it
Install husky with npm i -D husky
Create a simple config, e.g . echo '{ "hooks": { "pre-commit": "echo Hello World!" } }' > .huskyrc.json
Run npx husky-run pre-commit
npm v7 will fail with "could not determine executable", while npm v6 works

Environment:

OS: Ubuntu 20.04 or Windows 10 v2004
Node: 14.10.1
npm: 7.0.0-beta.11

The text was updated successfully, but these errors were encountered:

rafgraph · 2020-09-24T12:23:10Z

This might be related to #1834

csvn · 2020-09-24T13:03:48Z

@rafgraph On windows, I had no issues for hooks to be installed with Husky. When I used WSL on Ubuntu though, I had to use sudo for hooks to be installed, otherwise I had errors in the npm install log. So I don't think this is strictly related, since the error above can be reproduced by simply running npx husky-run pre-commit without hooks being installed at all.

darcyclarke · 2020-09-25T18:55:32Z

@csvn can you try installing the latest beta & seeing if you can repro? npm i -g npm@next-7. If you're still experiencing this, we'd love the debug.log

csvn · 2020-09-25T20:57:55Z

Hi @darcyclarke. Attached the output for the debug.log for the reproduction steps in the description.

0 verbose cli [
0 verbose cli   '/usr/local/bin/node',
0 verbose cli   '/usr/local/share/npm-global/lib/node_modules/npm/bin/npm-cli.js',
0 verbose cli   'exec',
0 verbose cli   '--',
0 verbose cli   'husky-run',
0 verbose cli   'pre-commit'
0 verbose cli ]
1 info using npm@7.0.0-beta.12
2 info using node@v14.10.1
3 timing config:load:defaults Completed in 2ms
4 timing config:load:file:/usr/local/share/npm-global/lib/node_modules/npm/npmrc Completed in 1ms
5 timing config:load:builtin Completed in 1ms
6 timing config:load:cli Completed in 1ms
7 timing config:load:env Completed in 0ms
8 timing config:load:file:/workspaces/npm-husky-test/.npmrc Completed in 0ms
9 timing config:load:project Completed in 1ms
10 timing config:load:file:/root/.npmrc Completed in 0ms
11 timing config:load:user Completed in 0ms
12 timing config:load:file:/usr/local/etc/npmrc Completed in 1ms
13 timing config:load:global Completed in 1ms
14 timing config:load:cafile Completed in 0ms
15 timing config:load:validate Completed in 0ms
16 timing config:load:setEnvs Completed in 1ms
17 timing config:load Completed in 7ms
18 verbose npm-session 53798df1482fef51
19 timing npm:load Completed in 13ms
20 http fetch GET 200 https://registry.npmjs.org/husky-run 832ms
21 timing command:exec Completed in 840ms
22 verbose stack Error: could not determine executable to run
22 verbose stack     at getBinFromManifest (/usr/local/share/npm-global/lib/node_modules/npm/lib/exec.js:210:23)
22 verbose stack     at exec (/usr/local/share/npm-global/lib/node_modules/npm/lib/exec.js:98:15)
23 verbose cwd /workspaces/npm-husky-test
24 verbose Linux 4.19.128-microsoft-standard
25 verbose argv "/usr/local/bin/node" "/usr/local/share/npm-global/lib/node_modules/npm/bin/npm-cli.js" "exec" "--" "husky-run" "pre-commit"
26 verbose node v14.10.1
27 verbose npm  v7.0.0-beta.12
28 error could not determine executable to run
29 verbose exit 1

I ran this within a Docker Devcontainer and WSL in VSCode. Environment info:

root@cc760b824422:/workspaces/npm-husky-test# npm -v
7.0.0-beta.12
root@cc760b824422:/workspaces/npm-husky-test# node -v
v14.10.1

csvn · 2020-09-25T21:03:26Z

This is the same for Windows, npm 7.0.0-beta.12 node v14.8.0:

0 verbose cli [
0 verbose cli   'C:\\Program Files\\nodejs\\node.exe',
0 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
0 verbose cli   'exec',
0 verbose cli   '--',
0 verbose cli   'husky-run',
0 verbose cli   'pre-commit'
0 verbose cli ]
1 info using npm@7.0.0-beta.12
2 info using node@v14.8.0
3 timing config:load:defaults Completed in 1ms
4 timing config:load:file:C:\Program Files\nodejs\node_modules\npm\npmrc Completed in 0ms
5 timing config:load:builtin Completed in 0ms
6 timing config:load:cli Completed in 1ms
7 timing config:load:env Completed in 1ms
8 timing config:load:file:C:\Users\Christian\Dev\@apptus\esales-fashion\.npmrc Completed in 1ms
9 timing config:load:project Completed in 1ms
10 timing config:load:file:C:\Users\Christian\.npmrc Completed in 1ms
11 timing config:load:user Completed in 1ms
12 timing config:load:file:C:\Program Files\nodejs\etc\npmrc Completed in 0ms
13 timing config:load:global Completed in 0ms
14 timing config:load:cafile Completed in 0ms
15 timing config:load:validate Completed in 0ms
16 timing config:load:setEnvs Completed in 1ms
17 timing config:load Completed in 6ms
18 verbose npm-session 3e0f43b059d2f137
19 timing npm:load Completed in 15ms
20 http fetch GET 200 https://registry.npmjs.org/husky-run 85ms
21 timing command:exec Completed in 95ms
22 verbose stack Error: could not determine executable to run
22 verbose stack     at getBinFromManifest (C:\Program Files\nodejs\node_modules\npm\lib\exec.js:210:23)
22 verbose stack     at exec (C:\Program Files\nodejs\node_modules\npm\lib\exec.js:98:15)
23 verbose cwd C:\Users\Christian\Dev\@apptus\esales-fashion
24 verbose Windows_NT 10.0.19041
25 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "exec" "--" "husky-run" "pre-commit"
26 verbose node v14.8.0
27 verbose npm  v7.0.0-beta.12
28 error could not determine executable to run
29 verbose exit 1

nlf · 2020-10-01T20:21:02Z

the issue here is that npx thinks you're trying to run husky-run the package rather than husky-run the bin script that's part of husky.

what you'll want to do to run the husky-run script within husky itself, is

npx -p husky husky-run

which informs npx which package contains the bin, and I can confirm works correctly

rafgraph · 2020-10-02T00:44:55Z

I get this same error could not determine executable to run when running husky as a pre-commit hook. Error log attached.

2020-10-02T00_36_01_041Z-debug.log

husky was installed with npm v6 (because of #1834), the pre-commit hook successfully setup. It is setup in package.json to run lint-staged as described in prettier docs. This works fine with npm v6

  "husky": {
    "hooks": {
      "pre-commit": "lint-staged"
    }
  },
  "lint-staged": {
    "src/**/*": "prettier --write --ignore-unknown"
  }

csvn · 2020-10-02T11:46:33Z

@nlf running npx husky-run is just for illustrating the problem. The real issue is that the hooks running with Husky fails when Husky executes them. So it is really the package that needs updating, if this issue is "working as intended". npx with npm v6 managed to find /node_modules/.bin/husky-run and run correctly. So this is a breaking change, and I was just curious if this is intended.

So in my mind, there are two options:

Ensure that npx <command> can find scripts in /node_modules/.bin if they match first
Update Husky so that it works with npm v7

I just wanted clarity which option is the right one, before opening an issue on Husky with this.

Coridyn · 2020-10-06T04:17:44Z

To add another data point, I think I'm running into the same issue with the vue-cli-service bin script (which works in npm@6).

$ npx vue-cli-service serve
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/vue-cli-service - Not found
npm ERR! 404
npm ERR! 404  'vue-cli-service@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

$ npx vue serve
npm ERR! could not determine executable to run

Based on nlf's comment there is a workaround until this is fixed in npm@7:

$ npx -p @vue/cli-service vue-cli-service serve

nlf · 2020-10-09T20:23:41Z

we published v7.0.0-rc.4 today that restores the old behavior of npx with regards to already installed scripts and should resolve these issues.

you can update with npm i -g npm@next-7 and let us know how it goes!

csvn · 2020-10-12T10:59:19Z

Thanks @nlf! I can verify that my Husky hooks now works again, same as with npm v6.

hanifmhd · 2021-01-26T17:07:29Z

Hi @nlf i still got error using npm v7.4.0

nlf · 2021-01-26T19:38:04Z

please open a new issue and be sure to fill out the template and i'll see if i can help figure out what's going on

tomalexhughes · 2021-02-04T15:13:27Z

Can confirm behaviour is working in 7.5.2 however I had to run npm rebuild to re-install husky's hooks. This may be helpful for you @hanifmhd

vijaycs85 · 2021-02-10T12:51:03Z

I got this issue with npx postcss and fixed it by removing the dist directory and running npx postcss again.

piotros · 2021-02-24T12:19:53Z

I ran into the same bug after upgrading husky from version 4 to 5.

Installing new version of package wasn't enough. The solution to fix this issue was to migrate husky to newer version.
There's a helpful tool for this task: https://github.com/typicode/husky-4-to-5

moshest · 2021-03-01T09:43:55Z

Thanks @piotros. I just follow the instructions here and fix it on my end as well:
https://typicode.github.io/husky/#/?id=locally-installed-binaries

cdefy · 2021-04-07T12:46:53Z

the issue here is that npx thinks you're trying to run husky-run the package rather than husky-run the bin script that's part of husky.

what you'll want to do to run the husky-run script within husky itself, is
npx -p husky husky-run
which informs npx which package contains the bin, and I can confirm works correctly

Hi there,

I hope I'm not making a mistake by posting here but the quoted answer is for me the closest to a solution.

I'm pretty sure you got that right because if I check the log it said "http fetch GET 304 https://registry.npmjs.org/husky-run 201ms" so I reckon it is looking for a package instead of running the script.

But I'm using Nuxt and I'm not sure how I can fix this as the solution offered is for the npm cli. If anyone has an idea it will be really appreciated.

Thanks!

EDIT : after more research, I found this StackOverFlow thread : https://stackoverflow.com/questions/66246587/how-to-fix-error-not-found-husky-run-when-committing-new-code
So I tried :

rm -rf .git/hooks
npm install

Seems to work OK now. 👍

3mmali · 2021-05-03T17:20:51Z

@nlf running npx husky-run is just for illustrating the problem. The real issue is that the hooks running with Husky fails when Husky executes them. So it is really the package that needs updating, if this issue is "working as intended". npx with npm v6 managed to find /node_modules/.bin/husky-run and run correctly. So this is a breaking change, and I was just curious if this is intended.

So in my mind, there are two options:

Ensure that npx <command> can find scripts in /node_modules/.bin if they match first

Update Husky so that it works with npm v7

I just wanted clarity which option is the right one, before opening an issue on Husky with this.

This was my issue! I had recently moved to a new machine and had forgotten to re-install npx.

VimalArjunan51437 · 2021-06-08T02:46:53Z

#while create new react app i am fcaing this issue

i have tried all command given above.

----->npx install create-react-app zoho

after given above cmd . i am facing below error

npm ERR! could not determine executable to run

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Admin\AppData\Local\npm-cache_logs\2021-06-08T02_41_23_166Z-debug.log

senjufy · 2021-07-27T09:33:26Z

I used npx tsc --init. Worked for me. Im on a linux machine, if that fact matters. I also have typescript installed globally with npm.

vedraan · 2021-09-14T12:11:34Z

the issue here is that npx thinks you're trying to run husky-run the package rather than husky-run the bin script that's part of husky.
what you'll want to do to run the husky-run script within husky itself, is
npx -p husky husky-run
which informs npx which package contains the bin, and I can confirm works correctly
Hi there,

I hope I'm not making a mistake by posting here but the quoted answer is for me the closest to a solution.

I'm pretty sure you got that right because if I check the log it said "http fetch GET 304 https://registry.npmjs.org/husky-run 201ms" so I reckon it is looking for a package instead of running the script.

But I'm using Nuxt and I'm not sure how I can fix this as the solution offered is for the npm cli. If anyone has an idea it will be really appreciated.

Thanks!

EDIT : after more research, I found this StackOverFlow thread : https://stackoverflow.com/questions/66246587/how-to-fix-error-not-found-husky-run-when-committing-new-code
So I tried :
rm -rf .git/hooks
npm install
Seems to work OK now. 👍

This is NOT a good way to fix it.

In fact you will completely remove all git hooks you have setup, so naturally there will be nothing to run and thus it will produce no error.

ljharb · 2021-09-14T16:54:47Z

Doesn't that indicate the problem is the hooks themselves, and not npm?

Samuel-B-D · 2021-09-29T20:19:05Z

Add "prepare": "husky install" as a script to package.json to fix it for everyone else when they will run npm install, then run npm run prepare to fix if for yourself.

( Note: this is done automatically for you when using the migration script here : https://github.com/typicode/husky-4-to-7 )

Moskaoud · 2022-11-15T11:42:14Z

npm i yarn
yarn install
then run command again npx husky-run pre-commit

kyawsan834 · 2023-08-17T18:30:18Z

not working

Due to incompatibility with more modern node versions, Husky thad to be upgraded according to these: https://github.com/npm/cli/issues/1845\#issuecomment-785037471 https://github.com/typicode/husky-4-to-8

csvn added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Sep 22, 2020

darcyclarke added the beta label Sep 25, 2020

darcyclarke removed the Needs Triage needs review for next steps label Sep 25, 2020

darcyclarke added this to the OSS - Sprint 16 milestone Sep 25, 2020

darcyclarke assigned nlf Oct 1, 2020

darcyclarke modified the milestones: OSS - Sprint 16, OSS - Sprint 17 Oct 5, 2020

darcyclarke mentioned this issue Oct 6, 2020

[BUG] npx binary does not account for globally-installed packages #1746

Closed

nlf mentioned this issue Oct 6, 2020

npx run existing bins #1906

Closed

csvn closed this as completed Oct 12, 2020

grahaml mentioned this issue Feb 18, 2021

[BUG] error 'could not determine executable to run' when using 'npm init' with a scoped package in a private registry #2726

Closed

whizzzkid mentioned this issue Mar 18, 2021

[BUG] npx does not work with single executable binaries #2894

Closed

Pranav016 mentioned this issue May 26, 2021

ReCaptcha Implementation ALPHAVIO/WordNook#642

Closed

pattishin mentioned this issue Aug 25, 2022

feat(experimental): oauth for lit client app GoogleCloudPlatform/emblem#568

Merged

cyonkee mentioned this issue Aug 31, 2023

FIX - add npm prepare script so husky v8 is setup and stops throwing errors Tradeshift/tradeshift-scripts#200

Draft

1 task

marcusicaro mentioned this issue Feb 29, 2024

fix: update husky ver luxedo/node-SPOS#15

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] npx fails with "could not find executable" when running husky in v7 #1845

[BUG] npx fails with "could not find executable" when running husky in v7 #1845

csvn commented Sep 22, 2020

rafgraph commented Sep 24, 2020

csvn commented Sep 24, 2020

darcyclarke commented Sep 25, 2020 •

edited

Loading

csvn commented Sep 25, 2020

csvn commented Sep 25, 2020

nlf commented Oct 1, 2020

rafgraph commented Oct 2, 2020

csvn commented Oct 2, 2020

Coridyn commented Oct 6, 2020

nlf commented Oct 9, 2020

csvn commented Oct 12, 2020

hanifmhd commented Jan 26, 2021

nlf commented Jan 26, 2021

tomalexhughes commented Feb 4, 2021

vijaycs85 commented Feb 10, 2021

piotros commented Feb 24, 2021 •

edited

Loading

moshest commented Mar 1, 2021

cdefy commented Apr 7, 2021 •

edited

Loading

3mmali commented May 3, 2021

VimalArjunan51437 commented Jun 8, 2021

senjufy commented Jul 27, 2021

vedraan commented Sep 14, 2021

ljharb commented Sep 14, 2021

Samuel-B-D commented Sep 29, 2021 •

edited

Loading

Moskaoud commented Nov 15, 2022

kyawsan834 commented Aug 17, 2023

[BUG] npx fails with "could not find executable" when running husky in v7 #1845

[BUG] npx fails with "could not find executable" when running husky in v7 #1845

Comments

csvn commented Sep 22, 2020

Current Behavior:

Expected Behavior:

Steps To Reproduce:

Environment:

rafgraph commented Sep 24, 2020

csvn commented Sep 24, 2020

darcyclarke commented Sep 25, 2020 • edited Loading

csvn commented Sep 25, 2020

csvn commented Sep 25, 2020

nlf commented Oct 1, 2020

rafgraph commented Oct 2, 2020

csvn commented Oct 2, 2020

Coridyn commented Oct 6, 2020

nlf commented Oct 9, 2020

csvn commented Oct 12, 2020

hanifmhd commented Jan 26, 2021

nlf commented Jan 26, 2021

tomalexhughes commented Feb 4, 2021

vijaycs85 commented Feb 10, 2021

piotros commented Feb 24, 2021 • edited Loading

moshest commented Mar 1, 2021

cdefy commented Apr 7, 2021 • edited Loading

3mmali commented May 3, 2021

VimalArjunan51437 commented Jun 8, 2021

senjufy commented Jul 27, 2021

vedraan commented Sep 14, 2021

ljharb commented Sep 14, 2021

Samuel-B-D commented Sep 29, 2021 • edited Loading

Moskaoud commented Nov 15, 2022

kyawsan834 commented Aug 17, 2023

darcyclarke commented Sep 25, 2020 •

edited

Loading

piotros commented Feb 24, 2021 •

edited

Loading

cdefy commented Apr 7, 2021 •

edited

Loading

Samuel-B-D commented Sep 29, 2021 •

edited

Loading