package-lock file changing based on local repository name

[NickAJScott]

Current Behavior:

package-lock.json changes depending on name of local copy of git repo, e.g. if i have two copies of the same repo locally one which matches the name in package.json and one which doesn't i get two different package-lock files, one specifies the name of the package in the inner packages list and one doesn't.

Expected Behavior:

package-lock.json should be independent of top level directory name, when working in a team there shouldn't be unnecessary changes to package-lock file due to a team member having a different local name of their git repository.

Steps To Reproduce:

1. clone a repository twice one in the default named directory and one into a name that differs from the repo name.
2. run npm install
3. two different package-lock files will be generated.

Environment:

• OS: Ubuntu 20.04
• Node: 15.3.0
• npm: 7.0.14

[NickAJScott]

I think this is in some ways similar to this issue here: #1767 The difference is the package.json does contain a name field, and when the repo name matches that name field the field is not being generated inside the package-lock.json. This means if you change the directory name the field will get generated, it seems it should be generated at all times.

[nlf]

i'm not able to reproduce this. do you have an example repo where you see this behavior? i tried cloning the same repo twice, removing the package-lock.json from both, and running npm i in both and the generated package-lock.json files match.

[NickAJScott]

Hi thanks for looking into this, ill try and create a dummy repo to reproduce it.

[NickAJScott]

@nlf Here is a repo to reproduce it: https://github.com/NickScottKortical/testpackagelock

commands i ran to see the issue were:

git clone git@github.com:NickScottKortical/testpackagelock.git
cd testpackagelock
npm install
git clone git@github.com:NickScottKortical/testpackagelock.git testpackagelock2
cd testpackagelock2
npm install

https://github.com/NickScottKortical/testpackagelock/compare/package_lock_changed

Shows the change that happens if the directory name doesn't match the name of the package, when the directory does match that name key isn't added at all and is what you see in the main branch.

[nlf]

confirmed! that reproduced it for me, thank you for taking the time!

[NickAJScott]

No problem, glad i could help :)

[apostolos]

Can reproduce, name is added on the CI, does not happen locally (folder is named "lwjgl.org" on local filesystem):