-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package-lock changes depending upon name of project folder #2770
Labels
Bug
thing that needs fixing
Duplicate
duplicate of another, existing issue
Release 7.x
work is associated with a specific npm 7 release
Comments
robross0606
added
Bug
thing that needs fixing
Needs Triage
needs review for next steps
Release 7.x
work is associated with a specific npm 7 release
labels
Feb 24, 2021
Also note that this looks super odd and brings up all sorts of questions:
|
Yes, it's perfectly valid JSON. |
Duplicate of #2264? |
Closing - Duplicate |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
thing that needs fixing
Duplicate
duplicate of another, existing issue
Release 7.x
work is associated with a specific npm 7 release
Current Behavior:
When using npm@7, if the folder name in which the project is being built matches the name of the project in
package.json
, aname
property is actively removed (or never set) from package-lock.json.If the project folder does not match the name in
package.json
then the property is actively set.This is a change controlled file by definition. At the very least, this can cause thrashing of
package-lock.json
if multiple developers are working on the same project and their working copies are in different folders.Expected Behavior:
The folder in which a project is checked out on the local file system should have zero bearing on the content of
package-lock.json
.Steps To Reproduce:
npm install
package-lock.json
and confirm that oddname
property does not exist.npm install
package-lock.json
and confirm that oddname
property does exist.Environment:
The text was updated successfully, but these errors were encountered: