Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Platform-specific optional dependencies not being included in package-lock.json when reinstalling with node_modules present #4828

Open
2 tasks done
JustinChristensen opened this issue Apr 29, 2022 · 197 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release

Comments

@JustinChristensen
Copy link

JustinChristensen commented Apr 29, 2022

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

[user@host:foo] $ npm -v
8.8.0
[user@host:foo] $ node
Welcome to Node.js v16.14.2.
Type ".help" for more information.
> process.arch
'arm64'

I'm working on a team that utilizes a mix of x64-based and m1-based macs, and has CI build processes that uses musl. We're seeing that npm is skipping platform-specific optional dependencies for packages such as @swc/core as a result of the package-lock.json file being generated without all of them included. In our case, this then causes linting to throw an exception, because one of our eslint plugins depends on @swc, which depends on having the platform specific @swc package also installed.

There seems to be at least two stages of cause to this. Firstly, when installing @swc/core from a clean slate working directory npm generates a package-lock.json with all of the optional dependencies for @swc/core listed:

[user@host:foo] $ npm install @swc/core
[user@host:foo] $ grep 'node_modules/@swc/core-*' package-lock.json
    "node_modules/@swc/core": {
    "node_modules/@swc/core-android-arm-eabi": {
    "node_modules/@swc/core-android-arm64": {
    "node_modules/@swc/core-darwin-arm64": {
    "node_modules/@swc/core-darwin-x64": {
    "node_modules/@swc/core-freebsd-x64": {
    "node_modules/@swc/core-linux-arm-gnueabihf": {
    "node_modules/@swc/core-linux-arm64-gnu": {
    "node_modules/@swc/core-linux-arm64-musl": {
    "node_modules/@swc/core-linux-x64-gnu": {
    "node_modules/@swc/core-linux-x64-musl": {
    "node_modules/@swc/core-win32-arm64-msvc": {
    "node_modules/@swc/core-win32-ia32-msvc": {
    "node_modules/@swc/core-win32-x64-msvc": {

And it only installs the platform specific package:

[user@host:foo] $ ls -l node_modules/@swc/
total 0
drwxr-xr-x  22 user  staff  704 Apr 29 15:39 core
drwxr-xr-x   6 user  staff  192 Apr 29 15:39 core-darwin-arm64

If I then remove my package-lock.json, leave my node_modules directory as-is, and then reinstall, I get:

[user@host:foo] $ rm -rf package-lock.json
[user@host:foo] $ npm install
[user@host:foo] $ grep 'node_modules/@swc/core-*' package-lock.json
    "node_modules/@swc/core": {
    "node_modules/@swc/core-darwin-arm64": {

That is, it then generates a package-lock.json with only the platform-specific dependency that was installed on this machine, and not with the other optional dependencies that should also be listed.

If you delete both node_modules AND package-lock.json, and then re-run npm install, it generates the correct lockfile with all of those optional dependencies listed.

The problem is that then, If the package-lock.json with the missing optional platform-specific dependencies gets checked into git and an x64 user pulls it down, or vice-versa, npm fails to detect that your platform's optional dependencies are missing in the lockfile and just silently skips installing the platform-specific dependency. For example, when I've got a package-lock.json that only contains the x64 @swc package because of the above problem (generated by my coworker on his x64 machine):

[user@host:foo] $ node
Welcome to Node.js v16.14.2.
Type ".help" for more information.
> process.arch
'arm64'
>
[user@host:foo] $ grep 'node_modules/@swc/core-*' package-lock.json
    "node_modules/@swc/core": {
    "node_modules/@swc/core-darwin-x64": {
[user@host:foo] $ ls
package-lock.json package.json

And I then install:

[user@host:foo] $ npm install
added 1 package in 341ms

1 package is looking for funding
  run `npm fund` for details
[user@host:foo] $ ls node_modules/@swc/
core

You can see that it fails to install the arm64 dependency or warn me in any way that the package-lock.json is missing my platform's dependency.

So yeah, two problems:

  1. npm is generating an inconsistent package-lock.json when node_modules has your platform-specific dependency installed.
  2. When installing from this inconsistent package-lock.json, npm fails to try to correct the problem by comparing the optional dependencies to what's listed upstream

Expected Behavior

  1. npm should preserve the full set of platform-specific optional deps for a package like @swc when rebuilding package-lock.json from an existing node_modules tree
  2. npm install should warn if the package-lock.json becomes inconsistent because of the first case

Steps To Reproduce

See above.

Environment

  • npm: 8.8.0
  • Node.js:
  • OS Name: OSX
  • System Model Name: Macbook Pro
[user@host:foo] $ npm -v
8.8.0
[user@host:foo] $ node -v
v16.14.2
[user@host:foo] $ uname -a
Darwin host.foo.com. 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T8101 arm64
[user@host] $ npm config ls
; "user" config from /Users/user/.npmrc
; node bin location = /Users/user/.nvm/versions/node/v16.14.2/bin/node
; node version = v16.14.2
; npm local prefix = /Users/user/Development/foo
; npm version = 8.8.0
; cwd = /Users/user/Development/foo
; HOME = /Users/user
; Run `npm config ls -l` to show all defaults.
@JustinChristensen JustinChristensen added Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release labels Apr 29, 2022
@JustinChristensen JustinChristensen changed the title [BUG] Platform-specific optional dependencies not being included in package-lock when reinstalling with node_modules/ present [BUG] Platform-specific optional dependencies not being included in package-lock when reinstalling with node_modules present Apr 29, 2022
@JustinChristensen JustinChristensen changed the title [BUG] Platform-specific optional dependencies not being included in package-lock when reinstalling with node_modules present [BUG] Platform-specific optional dependencies not being included in package-lock.json when reinstalling with node_modules present Apr 29, 2022
@JustinChristensen
Copy link
Author

@nlf

Sorry to ping you out of the blue, but this issue has been open for 11 days now without any movement. Is there anyone working on npm right now that might have the bandwidth to at least validate that this is indeed a problem as I've described it?

Just so that when someone does become available to do some development work they know that this is in the queue?

Please and thank you.

@JustinChristensen
Copy link
Author

Bump

@RobbieClarken
Copy link

I'm also encountering this issue with a Next.js project:

  • Deleting package-lock.json and running npm install on an M1 Mac results in a package-lock.json file that is no longer able to build the app on x86.
  • This can be fixed by deleting package-lock.json and node_modules and re-running npm install.

Unfortunately developers often don't realise the package-lock.json file is broken because everything continues to run fine on their machine. It is only when the build runs in CI that we learn it is broken.

Here is a reproduction:

$ node --version
v16.13.0
$ npm --version
8.12.1
$ npx create-next-app@latest
What is your project named? … my-app
Creating a new Next.js app in /Users/robbie/demo/my-app.
$ cd my-app/
$ npm install

up to date, audited 223 packages in 480ms

68 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
$ git status
On branch main
nothing to commit, working tree clean
$ rm package-lock.json
$ npm install

up to date, audited 223 packages in 579ms

68 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
$ # ************ package-lock.json is now incompatible with x86 ************
$ git diff
diff --git a/package-lock.json b/package-lock.json
index cbbf946..a87c1e5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -96,36 +96,6 @@
         "glob": "7.1.7"
       }
     },
-    "node_modules/@next/swc-android-arm-eabi": {
-      "version": "12.1.6",
-      "resolved": "https://registry.npmjs.org/@next/swc-android-arm-eabi/-/swc-android-arm-eabi-12.1.6.tgz",
-      "integrity": "sha512-BxBr3QAAAXWgk/K7EedvzxJr2dE014mghBSA9iOEAv0bMgF+MRq4PoASjuHi15M2zfowpcRG8XQhMFtxftCleQ==",
-      "cpu": [
-        "arm"
-      ],
-      "optional": true,
-      "os": [
-        "android"
-      ],
-      "engines": {
-        "node": ">= 10"
-      }
-    },
-    "node_modules/@next/swc-android-arm64": {
-      "version": "12.1.6",
-      "resolved": "https://registry.npmjs.org/@next/swc-android-arm64/-/swc-android-arm64-12.1.6.tgz",
-      "integrity": "sha512-EboEk3ROYY7U6WA2RrMt/cXXMokUTXXfnxe2+CU+DOahvbrO8QSWhlBl9I9ZbFzJx28AGB9Yo3oQHCvph/4Lew==",
-      "cpu": [
-        "arm64"
-      ],
-      "optional": true,
-      "os": [
-        "android"
-      ],
-      "engines": {
-        "node": ">= 10"
-      }
-    },
[...]
$ rm -r package-lock.json node_modules
$ npm install

added 222 packages, and audited 223 packages in 2s

68 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
$ # ************ package-lock.json is now ok again ************
$ git status
On branch main
nothing to commit, working tree clean

@pete55104
Copy link

I am also having this issue. I'm trying to run tests using jest with swc. The test runner is a linux image, but my dev machine is darwin. I can get it to work by either using --force to install the linux dependency, or I can install packages from inside the container... but github CI stands up the docker container in such a way that I can't easily install packages from in there, and that also prevents me from maintaining a cached node modules etc.

@johnculviner
Copy link

bump

@nikkhn
Copy link

nikkhn commented Jul 12, 2022

bump - cannot get optional dependencies (namely @swc/core-linux-arm64-gnu) to install on my linux distro

@sgoodluck
Copy link

bump

@alcuadrado
Copy link

Confirming that this issue is still present. It's particularly important for projects using NAPI modules, as tons of them use platform-specific packages.

jfsoul added a commit to guardian/prosemirror-typerighter that referenced this issue Sep 26, 2022
@AboldUSER
Copy link

Ran into this issue when creating a CI process for a repo where I use a Windows machine and the CI process is using Linux. My quick "fix" for now is to start the CI process by deleting the package-lock.json and running npm install instead of npm ci. I know this is not good practice, so looking forward to a real fix to come through.

@eliotSmithNYC
Copy link

bump

@douglassllc
Copy link

I am having a similar issue. My project uses @ffmpeg-installer/ffmpeg. While using npm v6 all optional dependencies (arch specific) are installed. After my upgrade to npm v8 the optional dependencies no longer install. Per the npm documentation I attempted using --include=optional, but this did not resolve the issue.

What has changed between v6 and v8 and is there an npm config option that will have v8 work similar to v6 when it comes to optional dependencies?

@Abadii
Copy link

Abadii commented Oct 30, 2024

I encountered a similar issue, and here’s how I resolved it.

I’m working on a MacBook Pro with an M2 Pro chip, while my GitLab pipeline runs on a Linux (x64) environment.

In my case, the problem stemmed from the rollup package not installing certain optional dependencies:

"optionalDependencies": {
        "@rollup/rollup-android-arm-eabi": "4.22.4",
        "@rollup/rollup-android-arm64": "4.22.4",
        "@rollup/rollup-darwin-arm64": "4.22.4",
        "@rollup/rollup-darwin-x64": "4.22.4",
        "@rollup/rollup-linux-arm-gnueabihf": "4.22.4",
        "@rollup/rollup-linux-arm-musleabihf": "4.22.4",
        "@rollup/rollup-linux-arm64-gnu": "4.22.4",
        "@rollup/rollup-linux-arm64-musl": "4.22.4",
        "@rollup/rollup-linux-powerpc64le-gnu": "4.22.4",
        "@rollup/rollup-linux-riscv64-gnu": "4.22.4",
        "@rollup/rollup-linux-s390x-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-musl": "4.22.4",
        "@rollup/rollup-win32-arm64-msvc": "4.22.4",
        "@rollup/rollup-win32-ia32-msvc": "4.22.4",
        "@rollup/rollup-win32-x64-msvc": "4.22.4",
        "fsevents": "~2.3.2"
      }

This package list is required by: @angular-devkit/build-angular@18.2.10 -> @angular/build@18.2.10 -> rollup@4.22.4.

In my package-lock.json, the necessary @rollup/rollup-darwin-arm64 was missing, even though it seemed required. Oddly, it was marked as optional. Running npm install --include=optional fixed this locally, updating my package-lock.json to include the needed packages, allowing ng serve to run smoothly.

To ensure consistency, I deleted the package-lock.json (a potentially risky step) and ran a fresh npm install --include=optional. This worked on my local machine but not in the pipeline, where the required linux-x64 packages were still missing.

To address this, I deleted package-lock.json again and ran npm install --platform=linux --arch=x64, adding include=optional to my .npmrc file. This generated a package-lock.json with all the necessary OS/architecture packages. Following this, npm install succeeded both locally and in the pipeline. Each environment correctly installed only the relevant packages (Darwin for macOS locally and Linux for the pipeline).

If you don’t mind deleting package-lock.json, this method might work for you too. Ensure the required packages are in package-lock.json before rerunning npm install with include=optional.

Best of luck!

@Abadii
Copy link

Abadii commented Oct 30, 2024

I encountered a similar issue, and here’s how I resolved it.

I’m working on a MacBook Pro with an M2 Pro chip, while my GitLab pipeline runs on a Linux (x64) environment.

In my case, the problem stemmed from the rollup package not installing certain optional dependencies:

"optionalDependencies": {
        "@rollup/rollup-android-arm-eabi": "4.22.4",
        "@rollup/rollup-android-arm64": "4.22.4",
        "@rollup/rollup-darwin-arm64": "4.22.4",
        "@rollup/rollup-darwin-x64": "4.22.4",
        "@rollup/rollup-linux-arm-gnueabihf": "4.22.4",
        "@rollup/rollup-linux-arm-musleabihf": "4.22.4",
        "@rollup/rollup-linux-arm64-gnu": "4.22.4",
        "@rollup/rollup-linux-arm64-musl": "4.22.4",
        "@rollup/rollup-linux-powerpc64le-gnu": "4.22.4",
        "@rollup/rollup-linux-riscv64-gnu": "4.22.4",
        "@rollup/rollup-linux-s390x-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-musl": "4.22.4",
        "@rollup/rollup-win32-arm64-msvc": "4.22.4",
        "@rollup/rollup-win32-ia32-msvc": "4.22.4",
        "@rollup/rollup-win32-x64-msvc": "4.22.4",
        "fsevents": "~2.3.2"
      }

This package list is required by: @angular-devkit/build-angular@18.2.10 -> @angular/build@18.2.10 -> rollup@4.22.4.

In my package-lock.json, the necessary @rollup/rollup-darwin-arm64 was missing, even though it seemed required. Oddly, it was marked as optional. Running npm install --include=optional fixed this locally, updating my package-lock.json to include the needed packages, allowing ng serve to run smoothly.

To ensure consistency, I deleted the package-lock.json (a potentially risky step) and ran a fresh npm install --include=optional. This worked on my local machine but not in the pipeline, where the required linux-x64 packages were still missing.

To address this, I deleted package-lock.json again and ran npm install --platform=linux --arch=x64, adding include=optional to my .npmrc file. This generated a package-lock.json with all the necessary OS/architecture packages. Following this, npm install succeeded both locally and in the pipeline. Each environment correctly installed only the relevant packages (Darwin for macOS locally and Linux for the pipeline).

If you don’t mind deleting package-lock.json, this method might work for you too. Ensure the required packages are in package-lock.json before rerunning npm install with include=optional.

Best of luck!

I encountered a similar issue, and here’s how I resolved it.

I’m working on a MacBook Pro with an M2 Pro chip, while my GitLab pipeline runs on a Linux (x64) environment.

In my case, the problem stemmed from the rollup package not installing certain optional dependencies:

"optionalDependencies": {
        "@rollup/rollup-android-arm-eabi": "4.22.4",
        "@rollup/rollup-android-arm64": "4.22.4",
        "@rollup/rollup-darwin-arm64": "4.22.4",
        "@rollup/rollup-darwin-x64": "4.22.4",
        "@rollup/rollup-linux-arm-gnueabihf": "4.22.4",
        "@rollup/rollup-linux-arm-musleabihf": "4.22.4",
        "@rollup/rollup-linux-arm64-gnu": "4.22.4",
        "@rollup/rollup-linux-arm64-musl": "4.22.4",
        "@rollup/rollup-linux-powerpc64le-gnu": "4.22.4",
        "@rollup/rollup-linux-riscv64-gnu": "4.22.4",
        "@rollup/rollup-linux-s390x-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-musl": "4.22.4",
        "@rollup/rollup-win32-arm64-msvc": "4.22.4",
        "@rollup/rollup-win32-ia32-msvc": "4.22.4",
        "@rollup/rollup-win32-x64-msvc": "4.22.4",
        "fsevents": "~2.3.2"
      }

This package list is required by: @angular-devkit/build-angular@18.2.10 -> @angular/build@18.2.10 -> rollup@4.22.4.

In my package-lock.json, the necessary @rollup/rollup-darwin-arm64 was missing, even though it seemed required. Oddly, it was marked as optional. Running npm install --include=optional fixed this locally, updating my package-lock.json to include the needed packages, allowing ng serve to run smoothly.

To ensure consistency, I deleted the package-lock.json (a potentially risky step) and ran a fresh npm install --include=optional. This worked on my local machine but not in the pipeline, where the required linux-x64 packages were still missing.

To address this, I deleted package-lock.json again and ran npm install --platform=linux --arch=x64, adding include=optional to my .npmrc file. This generated a package-lock.json with all the necessary OS/architecture packages. Following this, npm install succeeded both locally and in the pipeline. Each environment correctly installed only the relevant packages (Darwin for macOS locally and Linux for the pipeline).

If you don’t mind deleting package-lock.json, this method might work for you too. Ensure the required packages are in package-lock.json before rerunning npm install with include=optional.

Best of luck!

To clarify, now my package-lock.json includes the following:

......
"node_modules/@rollup/rollup-darwin-arm64": {
      "version": "4.22.4",
      "resolved": "xxx",
      "integrity": "xxx",
      "cpu": [
        "arm64"
      ],
      "dev": true,
      "license": "MIT",
      "optional": true,
      "os": [
        "darwin"
      ]
    },
    "node_modules/@rollup/rollup-darwin-x64": {
      "version": "4.22.4",
       "resolved": "xxx",
      "integrity": "xxx",
      "cpu": [
        "x64"
      ],
      "dev": true,
      "license": "MIT",
      "optional": true,
      "os": [
        "darwin"
      ]
    },
    "node_modules/@rollup/rollup-linux-arm-gnueabihf": {
      "version": "4.22.4",
       "resolved": "xxx",
      "integrity": "xxx",,
      "cpu": [
        "arm"
      ],
      "dev": true,
      "license": "MIT",
      "optional": true,
      "os": [
        "linux"
      ]
    },
    "node_modules/@rollup/rollup-linux-arm-musleabihf": {
      "version": "4.22.4",
       "resolved": "xxx",
      "integrity": "xxx",
      "cpu": [
        "arm"
      ],
      "dev": true,
      "license": "MIT",
      "optional": true,
      "os": [
        "linux"
      ]
    },
    "node_modules/@rollup/rollup-linux-arm64-gnu": {
      "version": "4.22.4",
       "resolved": "xxx",
      "integrity": "xxx",
      "cpu": [
        "arm64"
      ],
      "dev": true,
      "license": "MIT",
      "optional": true,
      "os": [
        "linux"
      ]
    },
etc ....

Before, these packages were missing in the package-lock.json file.

@lpknv
Copy link

lpknv commented Oct 30, 2024

I encountered a similar issue, and here’s how I resolved it.

I’m working on a MacBook Pro with an M2 Pro chip, while my GitLab pipeline runs on a Linux (x64) environment.

In my case, the problem stemmed from the rollup package not installing certain optional dependencies:

"optionalDependencies": {
        "@rollup/rollup-android-arm-eabi": "4.22.4",
        "@rollup/rollup-android-arm64": "4.22.4",
        "@rollup/rollup-darwin-arm64": "4.22.4",
        "@rollup/rollup-darwin-x64": "4.22.4",
        "@rollup/rollup-linux-arm-gnueabihf": "4.22.4",
        "@rollup/rollup-linux-arm-musleabihf": "4.22.4",
        "@rollup/rollup-linux-arm64-gnu": "4.22.4",
        "@rollup/rollup-linux-arm64-musl": "4.22.4",
        "@rollup/rollup-linux-powerpc64le-gnu": "4.22.4",
        "@rollup/rollup-linux-riscv64-gnu": "4.22.4",
        "@rollup/rollup-linux-s390x-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-gnu": "4.22.4",
        "@rollup/rollup-linux-x64-musl": "4.22.4",
        "@rollup/rollup-win32-arm64-msvc": "4.22.4",
        "@rollup/rollup-win32-ia32-msvc": "4.22.4",
        "@rollup/rollup-win32-x64-msvc": "4.22.4",
        "fsevents": "~2.3.2"
      }

This package list is required by: @angular-devkit/build-angular@18.2.10 -> @angular/build@18.2.10 -> rollup@4.22.4.

In my package-lock.json, the necessary @rollup/rollup-darwin-arm64 was missing, even though it seemed required. Oddly, it was marked as optional. Running npm install --include=optional fixed this locally, updating my package-lock.json to include the needed packages, allowing ng serve to run smoothly.

To ensure consistency, I deleted the package-lock.json (a potentially risky step) and ran a fresh npm install --include=optional. This worked on my local machine but not in the pipeline, where the required linux-x64 packages were still missing.

To address this, I deleted package-lock.json again and ran npm install --platform=linux --arch=x64, adding include=optional to my .npmrc file. This generated a package-lock.json with all the necessary OS/architecture packages. Following this, npm install succeeded both locally and in the pipeline. Each environment correctly installed only the relevant packages (Darwin for macOS locally and Linux for the pipeline).

If you don’t mind deleting package-lock.json, this method might work for you too. Ensure the required packages are in package-lock.json before rerunning npm install with include=optional.

Best of luck!

Thanks for this Infos. I will give it a try because I am experiencing similar issue.

@dultsch
Copy link

dultsch commented Nov 7, 2024

In the end it worked for me to add the following optional dependencies to get the standard angular 18 project running on my windows machine and the linux pipeline:

{
  "os": [
    "win32",
    "linux"
  ],
  "optionalDependencies": {
    "@lmdb/lmdb-linux-x64": "^3.0.13",
    "@lmdb/lmdb-win32-x64": "^3.0.13",
    "@rollup/rollup-win32-x64-msvc": "4.22.4",
    "@rollup/rollup-linux-x64-gnu": "4.22.4"
  }
}

As I had a fresh project, I regenerated the complete package-lock.json.

muodov added a commit to duckduckgo/autoconsent that referenced this issue Nov 7, 2024
* easylist experiment

* update easylist

* Tweak easylist hack

* delay easylist detection

* increase the easylist timeout

* update easylist

* Use fanboy-cookiemonster in the test extension

* Initialize and apply cosmetic filters together with prehide rules

* Fall back to filterist when no pop-up is found

* Remove easylist rule

* WIP

* WIP: add perf metrics

* add performance metrics

* Allow disabling autoconsent per site (in the test extension)

* Use uBO version of easylist cookie

* remove the perf metrics code

* Use constructed stylesheets for cosmetic styles

* minify the extension content script

* filterlist experiment

* Add filterlist overrides

* Update bundled filterlist

* minor filterlist changes

* Logging tweaks

* Tweak logs

* Add a rule for wise.com

* add a rule for nike

* Add a rule for dan.com

* Remove generic-cosmetic rule (too many false positives)

* add rule for medium.com

* Add a rule for abc.net.au

* Lint fix

* removed unused file

* support mobile aliexpress

* Update rule for temu

* Add rule for american airlines

* Add rule for tesla

* Wrap filterlist code in try catch

* Add a rule for admiral GDPR popups

* Tweak ensighten rule for britishairways.com

* Address minor PR comments

* comment overrides

* update the adblocker library and use the provided style override

* Bundle filterlist in JS

* Update filterlist on every release

* Tweak watch command

* Remove outdated comments

* Disable filterlist by default

* Move log to a more appropriate place

* remove unused ignore

* Lint fix in auto-generated file

* Update filterlist

* Remove autogenerated filterlist from git index

* Do not commit changes to filterlist

* Update the build scripts to update filterlist when necessary

* Regenerate package-lock (see npm/cli#4828)

* remove performance marks

* Produce separate builds with and without filterlist

* Avoid generating filterlist twice in ci

* Export json rules

* Do not commit filterlist file during release

* Build filterlist from easylist source

* Update readme

* add link to DDG download page

* cliqz/adblocker is renamed to ghostery/adblocker

* Address minor PR comments

* Track the resulting filterlist in git

* Add a ci job to update EasyList
jschaf added a commit to jschaf/bazel-rules-js-vite that referenced this issue Nov 7, 2024
I tried both optionalDependencies and dependencies.

Doesn't work. Fails with the same error:

```
/private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.3/node_modules/rollup/dist/native.js:63
                throw new Error(
                      ^

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at requireWithFriendlyError (/private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.3/node_modules/rollup/dist/native.js:63:9)
    at Object.<anonymous> (/private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.3/node_modules/rollup/dist/native.js:72:76)
    ... 3 lines matching cause stack trace ...
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
```
jschaf added a commit to jschaf/bazel-rules-js-vite that referenced this issue Nov 7, 2024
Results in same error. Rollup declares an optional dependency on the arm64 variant.

```
pnpm install && bazelisk run //:vite -- --help

private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.3/node_modules/rollup/dist/native.js:63
                throw new Error(
                      ^

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at requireWithFriendlyError (/private/var/tmp/_bazel_joe/1713d43747a35eb7e2009bc8fd9406b7/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.3/node_modules/rollup/dist/native.js:63:9)
```

It looks like rules_js doesn't link optional dependencies and also doesn't use the
package.json `pnpm.packageExtensions` override.

```
ls -lh $BAZEL_OUT/darwin_arm64-fastbuild/bin/vite_/vite.runfiles/_main/node_modules/.aspect_rules_js/rollup@4.24.4/node_modules

drwxr-xr-x@ 3 joe  wheel    96B Nov  7 13:35 @types
lrwxr-xr-x@ 1 joe  wheel   176B Nov  7 13:35 rollup -> $BAZEL_OUT/darwin_arm64-fastbuild/bin/node_modules/.aspect_rules_js/rollup@4.24.4/node_modules/rollup
```

https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1731014606302199?thread_ts=1730916056.708769&cid=CEZUUKQ6P
ha-ccoon added a commit to kuna-mata/kuna-talk-web that referenced this issue Nov 9, 2024
Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
ha-ccoon added a commit to kuna-mata/kuna-talk-web that referenced this issue Nov 9, 2024
Cannot find module @rollup/rollup-linux-x64-gnu.(npm/cli#4828).
SLaks added a commit to SLaks/tikkun.io that referenced this issue Nov 13, 2024
…4828

I deleted package-lock.json and node_modules, then ran `npm install --platform=linux --arch=x64 --include=optional`
SLaks added a commit to SLaks/tikkun.io that referenced this issue Nov 13, 2024
…4828

I deleted package-lock.json and node_modules, then ran `npm install --platform=linux --arch=x64 --include=optional`
freekh added a commit to valbuild/val that referenced this issue Nov 13, 2024
NorthernMan54 added a commit to homebridge/homebridge-config-ui-x that referenced this issue Nov 14, 2024
… related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
mgoudy91 pushed a commit to contentful/marketplace-partner-apps that referenced this issue Nov 15, 2024
mgoudy91 pushed a commit to contentful/marketplace-partner-apps that referenced this issue Nov 15, 2024
nwalters512 added a commit to orchidjs/tom-select that referenced this issue Nov 15, 2024
nwalters512 added a commit to orchidjs/tom-select that referenced this issue Nov 15, 2024
* Upgrade all dependencies

* Clean up package-lock.json

* Regenerate package-lock.json due to npm/cli#4828

* Downgrade chai
grund1k added a commit to htmlonelove/liga-astro-template that referenced this issue Nov 20, 2024
@pxCheney
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.