Skip to content

[DOCS] Possibly undesired and undocumented side-effects from #4917 #5001

Closed
@pvanagtmaal

Description

@pvanagtmaal

Is there an existing issue for this?

  • I have searched the existing issues

This is a CLI Docs Problem, not another kind of Docs Problem.

  • This is a CLI Docs Problem.

Description of Problem

Since #4917, workspace .gitignore files are taken into account. However, this means that if you have a typescript workspace, you likely have *.js files in your .gitignore and these will suddenly not be in the packlist anymore.

We have a monorepo, structured as follows:

├── .gitignore             # includes **/*.js and **/*.js.map
├── package.json           # private, to define the workspace
├── backend/
│        ├── package.json  # typescript project, published
│        ├── lib/
├── client/
│        ├── package.json  # typescript project, published
│        ├── lib/

Before npm 8.11.0, a npm pack for either backend or client would include the *.js and *.js.map files from lib, but since 8.11.0 only *.d.ts and index.js are packed. (I am not entirely sure why index.js is packed, I doubt it is relevant for this issue)

Potential Solution

I would have at least expected the change to be

  1. a major change so our CI would behave normally until we would do a major update (with the appropriate testing)
  2. documented properly (either here or in npm-packlist)

Affected URL

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Documentationdocumentation related issueNeeds Triageneeds review for next steps

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions