Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ECONNRESET in smoke tests #6793

Closed
lukekarrys opened this issue Sep 11, 2023 · 1 comment
Closed

[BUG] ECONNRESET in smoke tests #6793

lukekarrys opened this issue Sep 11, 2023 · 1 comment
Labels
Bug thing that needs fixing Priority 2 secondary priority issue regression:10.x Release 10.x

Comments

@lukekarrys
Copy link
Contributor

lukekarrys commented Sep 11, 2023

Current Behavior

The smoke test added in #6781 is failing (flaky) in Node 18 on macOS with ECONNRESET errors. This could be due to the new @npmcli/agent. I have not been able to reproduce this issue not in the smoke tests so I'm currently not sure of the severity of the issue.

The main difference in smoke tests is that they are calling npm via @npmcli/promise-spawn instead of directly. This is just a note and I'm not sure yet of its relevance.

Example of a flaky test run: https://github.com/npm/cli/actions/runs/6149382937/job/16685141474

Expected Behavior

The smoke tests pass without flakiness.

@lukekarrys lukekarrys added Bug thing that needs fixing Needs Triage needs review for next steps Release 10.x labels Sep 11, 2023
lukekarrys added a commit that referenced this issue Sep 15, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
lukekarrys added a commit that referenced this issue Sep 16, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
lukekarrys added a commit that referenced this issue Sep 16, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
lukekarrys added a commit that referenced this issue Sep 20, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
lukekarrys added a commit that referenced this issue Sep 20, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
wraithgar pushed a commit that referenced this issue Sep 20, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
@lukekarrys lukekarrys added Priority 2 secondary priority issue regression:10.x and removed Needs Triage needs review for next steps labels Oct 6, 2023
lukekarrys added a commit that referenced this issue Oct 6, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
lukekarrys added a commit that referenced this issue Oct 6, 2023
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
@lukekarrys
Copy link
Contributor Author

This was fixed by fixing the max sockets behavior in our http agent library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 2 secondary priority issue regression:10.x Release 10.x
Projects
None yet
Development

No branches or pull requests

1 participant