ls: show installed but unmet peer deps #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
release-next
branch
3 times, most recently
from
db63b89 to
b09bc8c
Compare
zkat
approved these changes
Jan 28, 2019
|
Yeah I noticed you force-pushed that commit into oblivion right after I based 4-5 PRs off it lol. No problem though, I'll change it tomorrow, it's late in my timezone. |
Any completely missing peer deps are filled in in the package tree, but with only a name and the version with which it is required, and some additional, derived metadata. However, if the dep does exist, but simply is the wrong version, it is still marked as a missing peer dep. This patch makes it so that `npm ls` does not hide *all* "missing" peer deps, but just the ones that are not installed in some way already. See https://npm.community/t/4770
aeschright
pushed a commit
that referenced
this pull request
Feb 14, 2019
PR-URL: #145 Fixes: https://npm.community/t/4770 Credit: @larsgw Reviewed-By: @aeschright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any completely missing peer deps are filled in in the package tree, but
with only a name and the version with which it is required, and some
additional, derived metadata. However, if the dep does exist, but simply
is the wrong version, it is still marked as a missing peer dep.
This patch makes it so that
npm lsdoes not hide all "missing" peerdeps, but just the ones that are not installed in some way already.
See https://npm.community/t/4770