Avoid blowing stack when checking if a failed dependency is required or optional #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failedDependency is depth first search for a path to a top-level or user-required package. If failedDependency revisits a package it will recurse till it blows the call stack.
everett1992
force-pushed
the
everett1992-patch-1
branch
from
049cafe
to
bf166ce
Compare
ruyadorno
added
pr: needs tests
|
hi @everett1992 thanks for your contribution! At this point we would def require a test demonstrating the failure in order to safely merge this change. 😊 I added the appropriate labels in case you or some other contributor have the time to put together some tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid blowing stack when checking if a failed dependency is required or optional
I see this issue in our private repository, I can't provide a public reproduction.
If I install a package with a cycle in it's dependencies and one of the packages in the cycle fails npm will error with
Maximum call stack size exceededand a track trace pointing tofailedDependency.