Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix build error from libvips + sharp #1555

Closed
wants to merge 1 commit into from

Conversation

christianbundy
Copy link

What / Why

Problem: Sharp doesn't play nicely with a globally-installed version of
libvips, and throws an error when you try to generate the documentation.
with npm run build:static. This has been documented as an issue in the
Gatsby issue tracker: gatsbyjs/gatsby#22303

Solution: Update the dependencies to pull in a new version of Sharp
which is immune to this problem. I ran npm update, which is supposed
to modify package.json, but it only changed package-lock.json. I
removed node_modules and ran npm install and can confirm that his
resolves the problem.

References

Problem: Sharp doesn't play nicely with a globally-installed version of
libvips, and throws an error when you try to generate the documentation.
with `npm run build:static`. This has been documented as an issue in the
Gatsby issue tracker: gatsbyjs/gatsby#22303

Solution: Update the dependencies to pull in a new version of Sharp
which is immune to this problem. I ran `npm update`, which is supposed
to modify `package.json`, but it only changed `package-lock.json`. I
removed `node_modules` and ran `npm install` and can confirm that his
resolves the problem.
@christianbundy christianbundy requested a review from a team as a code owner July 22, 2020 18:17
@ruyadorno
Copy link
Contributor

Hi @christianbundy, thanks for taking the time to contribute ❤️ We appreciate it!

Unfortunately with our focus switching to npm7, changes to the current npm6 release line are going to be limited to critical fixes for security issues and major bugs only.

I'm really curious if this fix really applies to our docs since we haven't been noticing any problems in the output files or the build currently. Let me know if that's the case then we can follow up with it either in v6 or v7 depending on the severity of the possible problem.

All the best and thanks again! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants