v7: npm view #1606
Closed
v7: npm view #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiahdz
force-pushed
the
test/v7-view
branch
from
edb018c to
8db5db1
Compare
ruyadorno
reviewed
Aug 4, 2020
| @@ -0,0 +1,492 @@ | |||
| const t = require('tap') | |||
| const mr = require('npm-registry-mock') | |||
There was a problem hiding this comment.
just a tip, I have been finding it way simpler to just mock the lib that reaches for the registry in the case of unit tests (in this case pacote) then setting up a complete registry mock
|
|
||
| dist | ||
| .tarball:[36mundefined[39m | ||
| .shasum:[33mundefined[39m |
There was a problem hiding this comment.
there are quite a few undefined all over the snapshots, are these expected due to the nature of the mocked data?
| [33m6[39m: [object Object] | ||
| [33m7[39m: [object Object] | ||
| [33m8[39m: [object Object] | ||
| [33m9[39m: [object Object] |
There was a problem hiding this comment.
were these supposed to be the name?
isaacs
pushed a commit
that referenced
this pull request
Aug 4, 2020
PR-URL: #1606 Credit: @claudiahdz Close: #1606 Reviewed-by: @isaacs
|
Landed on 87d27d3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm view refactor and unit tests