Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Always return JSON for outdated --json command #176

Closed
wants to merge 1 commit into from
Closed

Fix: Always return JSON for outdated --json command #176

wants to merge 1 commit into from

Conversation

sreeramjayan
Copy link

Return JSON when no outdated packages are found.
https://npm.community/t/npm-outdated-json-not-always-json/5953

@sreeramjayan sreeramjayan requested a review from a team as a code owner March 20, 2019 15:09
@isaacs
Copy link
Contributor

isaacs commented Jun 26, 2019

This seems like it'd result in printing out an empty list when --json isn't set. Maybe it should be if (er || silent || list.length === 0 && !opts.json) to have the intended effect?

@isaacs isaacs added in-progress semver:patch semver patch level for changes labels Jun 26, 2019
isaacs pushed a commit that referenced this pull request Jun 28, 2019
@isaacs
fix: Always return JSON for outdated --json
ab54475 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
isaacs pushed a commit that referenced this pull request Jun 28, 2019
@isaacs
fix: Always return JSON for outdated --json
eb10738 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
isaacs pushed a commit that referenced this pull request Jun 29, 2019
@isaacs
fix: Always return JSON for outdated --json
71abb16 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
isaacs pushed a commit that referenced this pull request Jun 29, 2019
@isaacs
fix: Always return JSON for outdated --json
4add798 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
isaacs pushed a commit that referenced this pull request Jun 29, 2019
@isaacs
fix: Always return JSON for outdated --json
d54e4e1 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
isaacs pushed a commit that referenced this pull request Jun 29, 2019
@isaacs
fix: Always return JSON for outdated --json
803c608 
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
@isaacs isaacs mentioned this pull request Jul 1, 2019
Merged
@isaacs isaacs closed this in 87fef4e Jul 3, 2019
@snyk-bot snyk-bot mentioned this pull request Aug 13, 2019
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 15, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 1, 2023
Open
@f4lco0n f4lco0n mentioned this pull request Jun 28, 2023
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Jun 28, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Oct 19, 2023
Closed
@soloinovator soloinovator mentioned this pull request Nov 29, 2023
Open
@soloinovator soloinovator mentioned this pull request Mar 23, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Apr 30, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 24, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreeramjayan @isaacs