-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow git to follow global tagsign config #185
Conversation
-a tells git to "ignore the git config for signing tags" that is all it does.
ie. this repo I want to sign tags and commits with this key, this repo I don't want to sign at all etc. So I use I would appreciate if tag signing would do the same as commit signing and respect the git config by not explicitly disabling it. |
This will be in 6.10 |
Current Behavior:
Expected Behavior:
My fix:
Other possible fix:
-a tells git to "ignore the git config for signing tags"
that is all it does.
Default is "not signed" anyways, so why not listen to the git config? Why explicitly forbid signing when the commit option follows git config and does not explicitly forbid signing unless the npm config says so?
If there is an explicit reason for forbidding signatures, I would like to hear it.
If this is a bug than it is a simple BUGFIX.
Workaround I've been using: (TIL about the npm config option to add tag signing)
So perhaps another way to fix this is to forbid signing of git commit without explicitly naming in npm config.
I think this difference between tag and commit handling is a bug.
Thank you for your review.