Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Installer when packaging git dependencies #189

Closed
wants to merge 1 commit into from
Closed

Use Installer when packaging git dependencies #189

wants to merge 1 commit into from

Commits on Apr 16, 2019

  1. Use Installer when packaging git dependencies

    This fixes a couple of config issues we've found when installing
    packages in `dry-run` mode to only get the lockfile changes.
    
    When setting `dry-run` or `ignore-scripts`, the setting isn't
    passed through when installing git dependencies meaning the `prepare`
    script is always run.
    
    We've also found an issue with proxying existing npm config to the cli
    when a large `cafile` has been set, as this is expanded into the `ca`
    config key with the full string contents of the ca file. If the ca file
    is huge this will blow up on linux with an E2BIG exception (Argument
    list too long). Increasing the limit requires kernel recompilation so
    isn't really an option.
    
    The current implementation requires `prepublish` to be fully deprecated,
    is this something you are planning? Otherwise I'm happy to find another
    way of passing this config through the installer.
    feelepxyz committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    e338460 View commit details
    Browse the repository at this point in the history