restore npm_config_user_agent env variable #1919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Oct 7, 2020
nlf
force-pushed
the
nlf/restore-user-agent-env
branch
from
2ca0ae9 to
9e46247
Compare
darcyclarke
added
the
Release 7.x
ruyadorno
pushed a commit
that referenced
this pull request
Oct 9, 2020
PR-URL: #1919 Credit: @nlf Close: #1919 Reviewed-by: @ruyadorno
|
landed in 09b456f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes move the setting of the user-agent config item to
@npmcli/configwhere it belongs, which in turn allows that module to export thenpm_config_user_agentenvironment variable.for: #1834