Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (failing) reproducible test case for ENOENT error #254

Closed

Conversation

salomvary
Copy link
Contributor

Source: https://npm.community/t/enoent-error-when-the-same-package-appears-in-local-dependencies/10099

I have no idea how to fix the bug but git bisect found 918f671 as the first commit failing this test. Does it mean this has been broken since 5.0.0?

@salomvary salomvary requested a review from a team as a code owner September 20, 2019 11:15
@salomvary
Copy link
Contributor Author

@isaacs
Copy link
Contributor

isaacs commented Sep 24, 2019

Comment from npm.community:

Thanks for the analysis and reproduction case! This is helpful.

Unfortunately, looking at the code, two things seem clear: first, you are correct, this has been broken since version 5.0.0. Second, it’s unlikely to be fixable before version 7.0.0. The changes required, while not in themselves breaking changes per se, will involve a lot of refactoring work of some components that are already being rewritten for v7.

I’ll add it to the list of cases that Arborist should handle properly, and ensure it gets in for v7.

@mikemimik mikemimik added the semver:major backwards-incompatible breaking changes label Sep 24, 2019
@claudiahdz claudiahdz added the Release 7.x work is associated with a specific npm 7 release label Nov 12, 2019
@darcyclarke
Copy link
Contributor

@salomvary sorry for the delay here. I'm going to close this PR as we have refactored this code heavily in v7 & are currently rewriting a lot of the test coverage. Thanks for the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:major backwards-incompatible breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants