-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] rewrite doctor tests to dictate the current node version #2681
Merged
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ef687f5 - Browse repository at this point
Copy the full SHA ef687f5View commit details -
fix(docs): fix angle brackets in npm diff docs
Emphasizing them like we do everywhere else to fix encoding errors and for consistency. Also removed the `<String>` from the type definition as we don't do that anywhere else. PR-URL: npm#2662 Credit: @ethomson Close: npm#2662 Reviewed-by: @wraithgar
Configuration menu - View commit details
-
Copy full SHA for 7e1e841 - Browse repository at this point
Copy the full SHA 7e1e841View commit details -
This brought in @npmcli/installed-package-contents@1.0.7 from commit e1822cf
Configuration menu - View commit details
-
Copy full SHA for 14dd938 - Browse repository at this point
Copy the full SHA 14dd938View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39e4a64 - Browse repository at this point
Copy the full SHA 39e4a64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96dffab - Browse repository at this point
Copy the full SHA 96dffabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a6e9d3 - Browse repository at this point
Copy the full SHA 9a6e9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 584b746 - Browse repository at this point
Copy the full SHA 584b746View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6305ebd - Browse repository at this point
Copy the full SHA 6305ebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e998811 - Browse repository at this point
Copy the full SHA e998811View commit details -
chore(package-lock): rebuild package-lock
This pulls in, installs, and de-dupes our subdependencies. Notable updates are promise-retry and @npmcli/move-file which had new versions but we had no way to update and/or dedupe We also manually removed uuid from our package.json which was only added in the past to try to get around this same deduping issue
Configuration menu - View commit details
-
Copy full SHA for 554d91c - Browse repository at this point
Copy the full SHA 554d91cView commit details
Commits on Feb 12, 2021
-
fix(tests): rewrite doctor tests
This decouples our tests from depending on the node version being right, and allows us to run in all of the environments we need to during CI. PR-URL: npm#2681 Credit: @ljharb Close: npm#2681 Reviewed-by: @wraithgar
Configuration menu - View commit details
-
Copy full SHA for 3a159d2 - Browse repository at this point
Copy the full SHA 3a159d2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.