-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependency wrappy #27
Remove unused dependency wrappy #27
Conversation
The dependency "wrappy" is nowhere used throughout the entire project which is why I removed it.
Do I also need to add the |
I would say "yes" assuming there are any changes as a result of |
@brodybits I just double checked and even removed the |
@rickschubert I stand corrected then, just updated my answer. I think the explanation is that the I would like to make an additional comment that I suspect |
@brodybits Thank you for the comments! Let's see what other people say, otherwise this PR can be gladly scrapped :) |
Allow me to clarify: This patch is also fine, because it gets rid of it, and it's normal that it wasn't removed from pkglock. It is, indeed, used by several dependencies:
And finally, to answer your questions about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! 👍
The dependency wrappy is nowhere used throughout the entire project which is why I removed it.