Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): remove flatOptions references #2892

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 17, 2021

Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.

This also moves our tests closer to using a real npm instance by having an interim mockNpm that acts like npm where we need it to.

Closes npm/statusboard#280

@wraithgar wraithgar requested a review from a team as a code owner March 17, 2021 20:53
@wraithgar wraithgar force-pushed the gar/flatoptions branch 2 times, most recently from 754fe69 to 30b8a07 Compare March 17, 2021 21:08
lib/diff.js Show resolved Hide resolved
lib/search.js Outdated Show resolved Hide resolved
const { force, silent, loglevel } = opts
const force = this.npm.config.get('force')
const silent = this.npm.config.get('silent')
const loglevel = this.npm.config.get('loglevel')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug, loglevel is not in flatOptions

isaacs
isaacs previously requested changes Mar 17, 2021
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some gotchas found, but +1 on the change overall.

lib/access.js Show resolved Hide resolved
lib/link.js Outdated Show resolved Hide resolved
lib/outdated.js Outdated Show resolved Hide resolved
lib/profile.js Show resolved Hide resolved
lib/publish.js Show resolved Hide resolved
lib/rebuild.js Show resolved Hide resolved
lib/utils/ping.js Show resolved Hide resolved
@wraithgar wraithgar requested a review from isaacs March 18, 2021 15:38
@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Mar 18, 2021
@ruyadorno ruyadorno dismissed isaacs’s stale review March 18, 2021 17:26

suggestions adressed

@ruyadorno ruyadorno added release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Mar 18, 2021
Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.

PR-URL: #2892
Credit: @wraithgar
Close: #2892
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno changed the base branch from latest to release-next March 18, 2021 17:28
@ruyadorno ruyadorno merged commit 889b06d into release-next Mar 18, 2021
isaacs pushed a commit that referenced this pull request Mar 18, 2021
Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.

PR-URL: #2892
Credit: @wraithgar
Close: #2892
Reviewed-by: @ruyadorno
isaacs pushed a commit that referenced this pull request Mar 18, 2021
Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.

PR-URL: #2892
Credit: @wraithgar
Close: #2892
Reviewed-by: @ruyadorno
@wraithgar wraithgar deleted the gar/flatoptions branch November 2, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(flatOptions): stop using flatOptions internally
5 participants