fix(publish): obey --ignore-scripts flag #3495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
Release 7.x
nlf
approved these changes
Jul 12, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
nice! this looks right to me
PR-URL: #3495 Credit: @wraithgar Close: #3495 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/publish-ignore-scripts
branch
from
b4fa09e to
feeb8e4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test also added to ensure the lifecycle scripts we DO want running are in fact running.
References
Closes #2755