Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist): use string-locale-compare #4465

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix(arborist): use string-locale-compare #4465

merged 1 commit into from
Feb 23, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Feb 23, 2022

I noticed this when reviewing #4464. We use @isaacs/string-locale-compare everywhere else, so I converted any relevant scripts/tests to use it as well. This should prevent future bugs like #4464 fixed.

@lukekarrys lukekarrys requested a review from a team as a code owner February 23, 2022 18:36
@lukekarrys lukekarrys force-pushed the patch-3 branch 3 times, most recently from f60b746 to 41110b1 Compare February 23, 2022 18:51
@npm-robot
Copy link
Contributor

npm-robot commented Feb 23, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 61.705 ±10.24 32.962 ±0.33 20.764 ±0.32 24.398 ±1.08 3.435 ±0.03 3.553 ±0.10 2.742 ±0.07 14.328 ±0.26 2.845 ±0.06 4.071 ±0.01
#4465 0.479 ±0.00 0.486 ±0.00 0.479 ±0.01 0.476 ±0.01 0.487 ±0.00 0.500 ±0.01 0.480 ±0.00 0.511 ±0.00 0.516 ±0.00 0.503 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.977 ±1.77 26.551 ±0.55 15.583 ±0.01 16.706 ±0.02 3.016 ±0.00 3.187 ±0.06 2.896 ±0.10 10.679 ±0.22 2.625 ±0.01 3.763 ±0.04
#4465 0.491 ±0.01 0.524 ±0.00 0.510 ±0.00 0.517 ±0.00 0.527 ±0.02 0.502 ±0.01 0.489 ±0.00 0.511 ±0.01 0.505 ±0.00 0.506 ±0.00

@lukekarrys lukekarrys merged commit 1b4385f into release-next Feb 23, 2022
@lukekarrys lukekarrys deleted the patch-3 branch February 23, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants