Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(libnpmpublish): unpublish from custom reg #4484

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Mar 1, 2022

Adds a test that ensures it's possible to unpublish a specific version
of a package from a custom registry (containing multiple slashes)

References

Relates to: #4253

Adds a test that ensures it's possible to unpublish a specific version
of a package from a custom registry (containing multiple slashes)

Relates to: #4253
@ruyadorno ruyadorno changed the base branch from latest to release-next March 1, 2022 15:19
@npm-robot
Copy link
Contributor

npm-robot commented Mar 1, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 50.710 ±0.29 35.626 ±0.34 26.903 ±7.11 24.606 ±0.93 3.434 ±0.03 3.487 ±0.19 2.884 ±0.05 15.174 ±0.26 2.848 ±0.01 3.992 ±0.10
#4484 0.519 ±0.01 0.547 ±0.01 0.532 ±0.00 0.507 ±0.01 0.516 ±0.01 0.500 ±0.01 0.508 ±0.02 0.491 ±0.01 0.507 ±0.02 0.515 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.881 ±0.24 27.484 ±0.16 16.563 ±0.32 17.433 ±0.01 3.464 ±0.01 3.419 ±0.06 2.985 ±0.12 11.181 ±0.26 2.788 ±0.05 3.760 ±0.02
#4484 0.502 ±0.01 0.550 ±0.05 0.532 ±0.01 0.513 ±0.03 0.558 ±0.01 0.528 ±0.00 0.512 ±0.01 0.510 ±0.00 0.542 ±0.02 0.505 ±0.01

@wraithgar wraithgar changed the base branch from release-next to latest March 9, 2022 18:23
@ruyadorno
Copy link
Contributor Author

Continued here: #4657

@ruyadorno ruyadorno closed this Mar 31, 2022
@lukekarrys lukekarrys deleted the ruyadorno/test-libnpmpublish-unpublish-custom-registry branch April 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants