Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix no-proxy to noproxy #46

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Conversation

jmannanc
Copy link
Contributor

Hello,

This is my first PR and I was looking through the NPM bug forum and saw this good-first-patch. Saw @zkat's fix and decided to open the PR. Sorry if this is wrong.

@jmannanc jmannanc requested a review from a team as a code owner August 13, 2018 23:48
@jmannanc jmannanc force-pushed the fix-no-proxy branch 2 times, most recently from 6321a5c to cf8e85f Compare August 14, 2018 00:38
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is perfect. You did great! Thanks for the patch! 🎉

@zkat zkat added the semver:patch semver patch level for changes label Aug 14, 2018
@jmannanc
Copy link
Contributor Author

Thank you 😃

@zkat zkat changed the base branch from latest to release-next August 20, 2018 22:31
@zkat zkat merged commit 05f473f into npm:release-next Aug 20, 2018
@jmannanc jmannanc deleted the fix-no-proxy branch August 20, 2018 23:12
zkat pushed a commit that referenced this pull request Aug 20, 2018
@zkat zkat mentioned this pull request Aug 29, 2018
4 tasks
@apaprocki
Copy link

@zkat Doesn't this have the nasty side effect of breaking everyone's npmrc that is using a private registry and a required no-proxy setting to access it?

isaacs added a commit that referenced this pull request Aug 5, 2019
wraithgar added a commit that referenced this pull request May 26, 2021
 * fix(exit-code): account for null auditLevel default (#46)
This was referenced May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants