Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-list cleanup #4609

Merged
merged 7 commits into from
Mar 28, 2022
Merged

cmd-list cleanup #4609

merged 7 commits into from
Mar 28, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 23, 2022

Lots of fixes here, please do not squash-merge this.

@wraithgar wraithgar requested a review from a team as a code owner March 23, 2022 22:25
@wraithgar
Copy link
Member Author

This was branched off of #4607, so that needs to land first then this can be rebased.

@wraithgar wraithgar marked this pull request as draft March 24, 2022 13:53
@npm-robot
Copy link
Contributor

npm-robot commented Mar 24, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 64.049 ±3.94 41.524 ±0.09 25.311 ±0.24 27.958 ±0.67 4.031 ±0.00 4.127 ±0.02 3.163 ±0.06 16.860 ±0.16 3.236 ±0.00 4.439 ±0.03
#4609 68.968 ±5.30 41.604 ±0.24 25.080 ±0.39 27.991 ±0.79 3.975 ±0.02 4.082 ±0.15 3.150 ±0.04 16.960 ±0.20 3.221 ±0.01 4.756 ±0.34
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 47.097 ±1.89 31.682 ±0.46 17.989 ±0.08 19.061 ±0.14 3.640 ±0.02 3.613 ±0.02 3.190 ±0.16 12.169 ±0.25 3.002 ±0.02 4.130 ±0.03
#4609 48.949 ±1.06 32.335 ±0.41 23.490 ±6.95 19.733 ±0.26 3.601 ±0.00 3.549 ±0.08 3.139 ±0.10 12.121 ±0.10 2.987 ±0.00 4.003 ±0.04

@wraithgar wraithgar force-pushed the gar/aliases branch 8 times, most recently from ed9faf6 to 33b67be Compare March 24, 2022 20:02
@wraithgar wraithgar marked this pull request as ready for review March 24, 2022 21:06
lib/commands/bin.js Show resolved Hide resolved
lib/utils/npm-usage.js Show resolved Hide resolved
lib/cli.js Outdated Show resolved Hide resolved
@lukekarrys lukekarrys merged commit 738a404 into latest Mar 28, 2022
@lukekarrys lukekarrys deleted the gar/aliases branch March 28, 2022 20:21
@lukekarrys lukekarrys mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants