Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(publish): add test for _auth with configured registry #4791

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 21, 2022

During #4763 it became apparent there was a test missing to show how _auth works with a configured registry (not a scope-configured registry)

@wraithgar wraithgar requested a review from a team as a code owner April 21, 2022 14:38
@wraithgar wraithgar force-pushed the gar/publish_auth_registry branch from 8116738 to 7cc1b05 Compare April 21, 2022 14:40
@npm-robot
Copy link
Contributor

npm-robot commented Apr 21, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 55.949 ±4.22 34.873 ±0.28 27.778 ±9.72 23.088 ±0.48 3.456 ±0.02 3.510 ±0.02 2.821 ±0.01 13.185 ±0.04 2.797 ±0.05 3.938 ±0.03
#4791 57.493 ±3.33 35.252 ±0.15 20.356 ±0.12 23.157 ±0.36 3.478 ±0.03 3.470 ±0.03 2.813 ±0.02 13.397 ±0.06 2.823 ±0.01 4.037 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.578 ±0.36 26.921 ±0.34 15.185 ±0.10 16.283 ±0.20 3.170 ±0.06 3.205 ±0.04 2.841 ±0.04 9.905 ±0.10 2.665 ±0.01 3.624 ±0.04
#4791 42.184 ±0.69 27.297 ±0.08 15.003 ±0.14 16.258 ±0.72 3.158 ±0.05 3.154 ±0.05 2.834 ±0.06 10.002 ±0.10 2.667 ±0.00 3.601 ±0.08

@lukekarrys lukekarrys merged commit 873ac7a into latest Apr 21, 2022
@lukekarrys lukekarrys deleted the gar/publish_auth_registry branch April 21, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants