Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document dependencies script #5095

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jun 28, 2022

adds documentation for the feature added to arborist in #5094, do not land this until after that feature

@nlf nlf requested a review from a team as a code owner June 28, 2022 21:09
Comment on lines +74 to +76
**dependencies**
* Runs AFTER any operations that modify the `node_modules` directory IF changes occurred.
* Does NOT run in global mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what env vars are available to help explain what changes occurred?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. as of today, none. i don't intend to export anything in the initial release of this feature.

we should discuss this in an rfc call and try to come to a consensus about what information is desirable here so that we don't have to ship a semver-major to change what we export later

@wraithgar wraithgar merged commit ac56fc4 into latest Jul 11, 2022
@wraithgar wraithgar deleted the nlf/docs-for-dependencies-script branch July 11, 2022 20:36
@wraithgar wraithgar mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants