Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore: Deprecate singular auth-type config values #5115

Closed
wants to merge 2 commits into from
Closed

[WIP] chore: Deprecate singular auth-type config values #5115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e3eb23
chore: Deprecate singular auth-type config values
jumoel Jun 28, 2022
a321b33
Docs
jumoel Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/using-npm/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1909,8 +1909,8 @@ When set to `dev` or `development`, this is an alias for `--include=dev`.

* Default: "legacy"
* Type: "legacy", "webauthn", "sso", "saml", or "oauth"
* DEPRECATED: The SSO/SAML/OAuth methods are deprecated and will be removed in
a future version of npm in favor of web-based login.
* DEPRECATED: The SSO/SAML/OAuth/Webauthn methods are deprecated and will be
removed in a future version of npm in favor of web-based login.

What authentication strategy to use with `adduser`/`login`.

Expand Down
1 change: 1 addition & 0 deletions lib/utils/config/definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const allowed = [
'default',
'defaultDescription',
'deprecated',
'deprecatedValues',
'description',
'flatten',
'hint',
Expand Down
3 changes: 2 additions & 1 deletion lib/utils/config/definitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,10 @@ define('auth-type', {
default: 'legacy',
type: ['legacy', 'webauthn', 'sso', 'saml', 'oauth'],
deprecated: `
The SSO/SAML/OAuth methods are deprecated and will be removed in
The SSO/SAML/OAuth/Webauthn methods are deprecated and will be removed in
a future version of npm in favor of web-based login.
`,
deprecatedValues: ['webauthn', 'sso', 'saml', 'oauth'],
description: `
What authentication strategy to use with \`adduser\`/\`login\`.

Expand Down
4 changes: 2 additions & 2 deletions tap-snapshots/test/lib/utils/config/definitions.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ exports[`test/lib/utils/config/definitions.js TAP > config description for auth-

* Default: "legacy"
* Type: "legacy", "webauthn", "sso", "saml", or "oauth"
* DEPRECATED: The SSO/SAML/OAuth methods are deprecated and will be removed in
a future version of npm in favor of web-based login.
* DEPRECATED: The SSO/SAML/OAuth/Webauthn methods are deprecated and will be
removed in a future version of npm in favor of web-based login.

What authentication strategy to use with \`adduser\`/\`login\`.

Expand Down