Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dependency-selectors): fix Arborist example in docs #5328

Merged
merged 2 commits into from
Aug 24, 2022
Merged

docs(dependency-selectors): fix Arborist example in docs #5328

merged 2 commits into from
Aug 24, 2022

Conversation

kyle-west
Copy link
Contributor

@kyle-west kyle-west commented Aug 19, 2022

Arborist.loadActual is an async function. The docs show it as a callback pattern. Also, await's were being used without being inside an async function. This change fixes those examples.

References

Mirrored in npm/documentation#178

@kyle-west kyle-west requested a review from a team as a code owner August 19, 2022 16:33
@kyle-west kyle-west changed the title [dependency-selectors] fix example in docs [dependency-selectors] fix Arborist example in docs Aug 19, 2022
@lukekarrys lukekarrys changed the title [dependency-selectors] fix Arborist example in docs docs(dependency-selectors): fix Arborist example in docs Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants