fix: Turn off progress bar when using web based authorization #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
approved these changes
Aug 29, 2022
Merged
This was referenced Sep 2, 2022
This was referenced Sep 7, 2022
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for web based authorization was added for all commands as part of #5098. At that time only
publishsupported web based authorization on registry side and to fix unintended output after the URL we disabled progress bar forpublishas helpfully suggested by @wraithgar in this Slack thread.As part of https://github.com/github/npm/issues/5736 we are updating registry to support web based authorization for all commands which require TFA. To support that change this PR disables progress bar in a central place within
otpleasewhen registry requiresWebOTPto avoid the additional unintended output displayed after URL as seen in 👇🏻 screen recordings.Before Fix
Screen.Recording.2022-08-29.at.7.03.10.PM.mov
After Fix
Screen.Recording.2022-08-29.at.7.06.59.PM.mov
References
Resolves github/npm#6111
cc @jumoel @neeldani @MylesBorins