Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default install-links to true #5458

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: default install-links to true #5458

merged 1 commit into from
Sep 8, 2022

Conversation

wraithgar
Copy link
Member

BREAKING CHANGE: this changes the default value of install-links to
true

Closes npm/statusboard#510

@wraithgar wraithgar requested a review from a team as a code owner September 1, 2022 15:34
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 1, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.285 ±1.39 18.573 ±0.74 16.314 ±0.33 20.883 ±3.65 2.867 ±0.03 2.851 ±0.00 2.453 ±0.17 11.063 ±0.11 2.305 ±0.00 3.370 ±0.01
#5458 44.082 ±2.15 18.561 ±0.01 16.454 ±0.26 18.931 ±0.39 2.898 ±0.02 2.908 ±0.02 2.385 ±0.00 11.427 ±0.00 2.320 ±0.02 3.481 ±0.05
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 31.839 ±1.80 13.946 ±0.02 12.304 ±0.02 13.147 ±0.84 2.570 ±0.01 2.563 ±0.01 2.321 ±0.02 8.179 ±0.04 2.182 ±0.00 3.040 ±0.02
#5458 29.576 ±0.80 13.762 ±0.12 12.201 ±0.15 13.164 ±0.74 2.573 ±0.03 2.682 ±0.03 2.304 ±0.01 8.066 ±0.00 2.142 ±0.01 2.953 ±0.00

BREAKING CHANGE: this changes the default value of `install-links` to
true

Closes npm/statusboard#510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE(install): default to --install-links=true
3 participants