New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm cache completion #6464

Merged

wraithgar merged 1 commit into npm:latest from m4rch3n1ng:fix-npm-cache-completion

May 17, 2023

Contributor

m4rch3n1ng commented May 17, 2023

the bash completions npm cache show an extra command (npm cache delete) that does not exist and throws EUSAGE. this removes that command.


          fix npm cache completion

0d1c17c

m4rch3n1ng requested a review from a team as a code owner

May 17, 2023 21:08

wraithgar changed the title ~~fix npm cache completion~~ fix: npm cache completion

wraithgar approved these changes

View reviewed changes

wraithgar merged commit 9202c7d into npm:latest

m4rch3n1ng deleted the fix-npm-cache-completion branch

May 17, 2023 21:17

github-actions bot mentioned this pull request

chore: release 9.6.7 #6429

Merged

npm-cli-bot mentioned this pull request

deps: upgrade npm to 9.6.7 nodejs/node#48062

Merged

guru-aot mentioned this pull request

2535 - Crash Loop Back offs Error bcgov/SIMS#2577

Merged

4 tasks

guru-aot added a commit to bcgov/SIMS that referenced this pull request


          2535 - Crash Loop Back offs Error (#2577)

438a2e4

Note: The branch name is created without a # in the front, to test my
build and deployments from my local.

- [x] Investigate the issue and apply the fix on all our custom
Dockerfile (Api, web, workers, queue-consumers, load-test-gateway &
db-migration)
- [x] Most updated image in node has to be deployed


What does EACCES error means in node -
https://betterstack.com/community/guides/scaling-nodejs/nodejs-errors/#13-eacces

On Analysing the issue, i was able to understand that this issue happens
in certain version of node & npm libraries, some related bugs reported
in the years are given below for reference.
- npm/cli#5114
- https://stackoverflow.com/questions/71450392/npm-cache-issue
-
https://stackoverflow.com/questions/67163194/jenkins-build-issue-npm-err-your-cache-folder-contains-root-owned-files

The possible solutions given by the people are alwauys these 2
- give sudo permission and access for the user 1001 for the /.npm
directory/ - which is not always right to have a sudo persmission for a
user in dockerfile
- upgrade the node version as it states to a newer version that this
issue is not happening - going with this route as we have a newer
version of redhat that contains the new version from the one deplyoed
already with some security issues.


https://catalog.redhat.com/software/containers/ubi8/nodejs-18/6278e5c078709f5277f26998?architecture=amd64&image=65302e01ec5935b621691d22&container-tabs=packages

![image](https://github.com/bcgov/SIMS/assets/62901416/1f7136b4-3daf-43d3-9af3-6232865be1e3)


https://catalog.redhat.com/software/containers/ubi8/nodejs-18/6278e5c078709f5277f26998?architecture=amd64&image=6543c3d67371c4bd3014291a&container-tabs=packages
<img width="1290" alt="image"
src="https://github.com/bcgov/SIMS/assets/62901416/a492658d-bd7f-4a92-9513-2b26038a475c">

Analyzing the changelogs of npm js, there has been bugs related to cache
that has been fixed.
https://docs.npmjs.com/cli/v9/using-npm/changelog#981-2023-07-18
https://docs.npmjs.com/cli/v9/using-npm/changelog#967-2023-05-17


![image](https://github.com/bcgov/SIMS/assets/62901416/e35782a3-28f3-4c5c-982b-58b06ac6404b)
npm/cli#6464
The bug reported may not state the same issue we are facing but its
related to the cache error that is happening in the version we were
using.

So updating the redhat image to the latest version is what was taken as
an action to solve this issue.

Note:
https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2453
is also done as part of this PR.
- [x] Remove variables from Makefile
- [x] Remove references from docker-build.yml


As suggested by @andrewsignori-aot
#2577 (comment) changed
the permission of users in the group 0 for the folder ./.npm to have
write access

Container before assigning the write permission
<img width="889" alt="image"
src="https://github.com/bcgov/SIMS/assets/62901416/a8d95861-d538-4661-9e6c-429b30f2f6e3">

Container after assigning the write permission
<img width="740" alt="image"
src="https://github.com/bcgov/SIMS/assets/62901416/2343b44b-2b4b-4849-8f55-084beea91d0b">


Addded only the permissions for the ./.npm folder as in the past month
the failed logs show this error happening only in the ./.npm folder.

https://kibana-openshift-logging.apps.silver.devops.gov.bc.ca/app/kibana#/discover?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-30d,mode:quick,to:now))&_a=(columns:!(message),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'8841c680-a15b-11eb-a4dc-e5bf19f04239',key:kubernetes.namespace_name,negate:!f,params:(query:'0c27fb-test',type:phrase),type:phrase,value:'0c27fb-test'),query:(match:(kubernetes.namespace_name:(query:'0c27fb-test',type:phrase))))),index:'8841c680-a15b-11eb-a4dc-e5bf19f04239',interval:auto,query:(language:lucene,query:'%22sudo%20chown%20-R%20%22'),sort:!('@timestamp',desc))

<img width="923" alt="image"
src="https://github.com/bcgov/SIMS/assets/62901416/ba796f55-5447-4c4a-9fef-aba1ab129d5c">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet