Merge GitLab provenance generation into latest #6525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first pass at provenance generation for GitLab CI. This is based loosely off of existing GitLab provenance documents: https://about.gitlab.com/blog/2022/11/30/achieve-slsa-level-2-compliance-with-gitlab/ https://gist.github.com/wlynch/c7fd8f53adc77d3c0ec82356e4d43cb5
Merges gitlab provenance generation into latest branch. See working example at https://www.npmjs.com/package/@ps-testing/gitlab-npm-provenance#provenance
feelepxyz
reviewed
Jun 6, 2023
| @@ -15828,6 +15828,7 @@ | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "ci-info": "^3.6.1", | |||
| "libnpmpublish": "file:", | |||
feelepxyz
reviewed
Jun 6, 2023
| const GITHUB_BUILD_TYPE_VERSION = 'v2' | ||
|
|
||
| const GITLAB_BUILD_TYPE_PREFIX = 'https://github.com/npm/cli/gitlab' | ||
| const GITLAB_BUILD_TYPE_VERSION = 'v0alpha1' |
There was a problem hiding this comment.
Any point bumping this to something like v0beta1?
@wlynch thanks for opening this up! I would like to hold off merging this until we've fixed up some of the links in the UI. Should get this done this week. |
|
I think the PR that we want to land is the actual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges #6375 into latest.
We were waiting on a working example in the npm UI, which we now have with https://www.npmjs.com/package/@ps-testing/gitlab-npm-provenance#provenance
There are some additional Fulcio claim changes being discussed in sigstore/fulcio#1206, but this shouldn't affect anything with npm cli.
/cc @feelepxyz
References
Fixes #6373