Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: public package check in libnpmpublish #6530

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

bdehamer
Copy link
Contributor

@bdehamer bdehamer commented Jun 6, 2023

Removes a stray "true" in the boolean expression which determines whether the package's access is "public". Result of a bad refactor of the original implementation

Does not change behavior.

Removes a stray "true" in the boolean expression which determines
whether the package's access is "public". Does not change behavior.

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner June 6, 2023 18:10
@wraithgar
Copy link
Member

Will likely want to land #6526 first so we can fix merge conflicts here rather than there.

@wraithgar wraithgar merged commit 29622c1 into latest Jun 13, 2023
@wraithgar wraithgar deleted the bdehamer/libnpmpublish-provenance-fix branch June 13, 2023 18:45
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants