feat: add ps1 scripts

[mribbons]

Resolves UNC path issues because powershell.exe
supports UNC, while cmd.exe doesn't.
(Which is why npm.cmd doesn't work within
UNC paths, even under powershell)

Added ps1 versions of npm and npx

Closes #6280

[lukekarrys]

I'd like to get a better idea of how you are currently running these scripts on your system. You mention installing them here $(Get-Command "npm").Source, what directory is that on your machine? How have you previously installed Node on this machine (and npm if that was installed differently)?

This can be merged into npm, but I believe it will require coordination with Node in order for this to land and have it work when installing Node on Windows. Currently the Node Windows installers (of which I know very little about) reference npm.cmd in the locations below. I'm assuming something similar will need to be done with npm.ps1 to have it work as expected in these system.

• /tools/msvs/msi/nodemsi/product.wxs
• /tools/msvs/nodevars.bat
• /vcbuild.bat

@mribbons Would you be able to open an issue or PR on https://github.com/nodejs/node to get feedback on how the Windows installers work, and if it would be appropriate for npm to ship these ps1 scripts in our bin/ dir and have them picked up by the installer?

Also in the meantime, would shipping these scripts in the npm bin dir, even if they dont get linked via the Windows installer, fix #6280?

[lukekarrys]

Also this will need to land with some tests in test/bin/windows-shims.js.

@mribbons If you want to attempt that, go for it. Otherwise I will work on those.

[lukekarrys]

Requesting changes until we have feedback from Node and tests.

[mribbons]

@mribbons If you want to attempt that, go for it. Otherwise I will work on those.

I'll give it a shot!

[mribbons]

@lukekarrys

what directory is that on your machine?

C:\Program Files\nodejs\npm.ps1

How have you previously installed Node on this machine

Using Windows Installer from node

Would you be able to open an issue or PR

nodejs/node#48471

Also in the meantime, would shipping these scripts in the npm bin dir, even if they dont get linked via the Windows installer, fix #6280?

My guess is no, the new scripts probably won't be deployed by the installer.

Thanks for your help.

[lukekarrys]

@mribbons I pushed a commit to this PR implementing tests for the powershell scripts you added.

I did make one minor change to the scripts to match the behavior of the other bin scripts, so they now run node npm-cli.js prefix -g to see if there is a symlinked npm that should be used instead.

I'm not sure if all the tests will pass cleanly here since I've been doing some Windows cleanup in #6586 that might need to merge first. But I tested the combination of that PR and this one on my local machine and it worked.

Edit: tests are failing but will be fixed once #6586 and eol normalization lands. Once it does I'll rebase this branch to make sure tests are passing.

[mribbons]

@lukekarrys You are the man, thankyou!

Code has been updated and needs a new reviewer thats not me

[lukekarrys]

This has been rebased to include the changes from #6586 so that tests will pass. That PR will need to be merged first.