Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message for newer node version #684

Closed
wants to merge 2 commits into from
Closed

Update message for newer node version #684

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2020

What / Why

This makes the message more clear, since it says you have to use a newer version of node even if the version is too new for npm

It also prevents error messages like this:

npm WARN npm npm does not support Node.js v10.15.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/

@ghost ghost self-requested a review as a code owner January 12, 2020 20:56
@mikemimik mikemimik added Community Needs Discussion is pending a discussion Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Jan 13, 2020
@mikemimik
Copy link
Contributor

mikemimik commented Jan 13, 2020

Hello @raspberrypifan thanks for making a pull-request!

I added the needs discussion label to this issue because I think the team wants to push people towards the latest version, rather than just a newer one. We'll give it a talk over though and definitely get back to you! :D

@darcyclarke darcyclarke added this to the OSS - Sprint 2 milestone Jan 14, 2020
@darcyclarke darcyclarke removed the Needs Discussion is pending a discussion label Jan 14, 2020
@mikemimik mikemimik requested a review from darcyclarke January 21, 2020 17:33
@darcyclarke
Copy link
Contributor

@raspberrypifan Appreciate the contribution here! That said, I think we're going to leave the current messaging the way it is. We definitely have the "supported versions" logic on our radar to change/improve going forward though (ie. to help address/correct false positives).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants