-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preinstallOnly
script
#6888
Conversation
What / Why
|
I got the idea to use
|
This would constitute a breaking change and would have to wait till npm 11 |
Why would a new script be a breaking change? |
Ah my oversight, I thought this was moving an existing script |
I was able to test it out locally just now, and it appears to work as intended. |
package.json.-.cli.WSL_.Ubuntu.-.Visual.Studio.Code.2023-10-10.16-23-47.mp4 |
Works well on mine. |
Any word on when this will release? My team is switching to pnpm also and running into exactly this problem where someone accidentally runs npm install and we can't prevent it. |
@wraithgar what changes would you like this pull request to have, to consider merging it? |
This is a great contribution and it seems to fit into a point of the install lifecycle that might not be fully covered yet. Our team is currently reviewing the npm lifecycle hooks as a whole and the best resolutions for it moving forward. Unfortunately this means we won't be able to accept this new feature knowing it may eventually be affected by a breaking change. |
Okay, thanks for the explanation. |
No description provided.