Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm link does not respect --no-save #6910

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

Santoshraj2
Copy link
Contributor

Issue: #3619
there was no condition to capture no-save scenario, read that from CLI and included condition to check that which will end up not saving anything if -no-save is passed as arguments.

@Santoshraj2 Santoshraj2 requested a review from a team as a code owner October 17, 2023 17:39
lib/commands/link.js Outdated Show resolved Hide resolved
@wraithgar
Copy link
Member

It looks like we may be hitting coverage by accident here. I would expect a test that sets save to false, and has find return cli, and then assert that it is not saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants