Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly catch missing url opener error #6951

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: properly catch missing url opener error #6951

merged 1 commit into from
Nov 6, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Oct 31, 2023 •
edited
Loading

npm used to use opener, which called childProcess.execFile
npm now uses @npmcli/promise-spawn which uses childProcess.open

The 'not found' error is different between those two methods

@wraithgar wraithgar requested a review from a team as a code owner October 31, 2023 21:09
@wraithgar wraithgar merged commit dce3b08 into latest Nov 6, 2023
21 checks passed
@wraithgar wraithgar deleted the gar/open-error-code branch November 6, 2023 16:46
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 15, 2023
Merged
@wraithgar wraithgar mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @lukekarrys